Fix for missing default settings at startup. - #8172
Conversation
| if (context == null) { | ||
| return null; | ||
| // use first clientcontext as default | ||
| context = _clientContexts.First(); |
There was a problem hiding this comment.
Is there a FirstOrNull thing? I wasn't sure if this would throw if there's no items in the list.
There was a problem hiding this comment.
Oh it's called 'FirstOrDefault'. Maybe you should use that?
There was a problem hiding this comment.
i check count at the top of the function. but ya. that would be safer
5eefffc to
adb386e
Compare
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adb386e
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
guard against no context elements on shutdown. A context is created for the project or for each workspace or for each repl.
e86f5f4 to
db8ae5e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
4 participants
guard against no context elements on shutdown. A context is created for the project or for each workspace or for each repl.
We need to send tasklist info when sending default settings with "workspace/didChangeConfiguration".
alternatively we could pass in the uri into GetSettings() when "TriggerWorkspaceUpdateConfig" is called.
Fix for #8121