Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.microsoft.mrtk.windowsspeech's strong dependency on com.microsoft.mrtk.tts.windows #11453

Closed
AMollis opened this issue Apr 6, 2023 · 0 comments
Labels
Feature Request Feature request from the community IssueMigrated MRTK3
Milestone

Comments

@AMollis
Copy link
Member

AMollis commented Apr 6, 2023

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:


Describe the problem

The WindowsTextToSpeechSubsystem is inside the com.microsoft.mrtk.windowsspeech package, and WindowsTextToSpeechSubsystem requires com.microsoft.mrtk.tts.windows. Given this strong dependency, and app is required to include com.microsoft.mrtk.tts.windows even if it doesn't require text-to-speech (TTS).

Describe the solution you'd like

Either update com.microsoft.mrtk.windowsspeech so that it disables TTS code paths if the com.microsoft.mrtk.tts.windows package is not included. Or move WindowsTextToSpeechSubsystem into a different package.

Describe alternatives you've considered

  1. Leave everything as is, and always require com.microsoft.mrtk.tts.windows.
  2. Move com.microsoft.mrtk.tts.windows into com.microsoft.mrtk.windowsspeech

Additional context

It's unclear as to why WindowsTextToSpeechSubsystem wasn't in com.microsoft.mrtk.tts.windows in the first place.

@AMollis AMollis added Feature Request Feature request from the community MRTK3 labels Apr 6, 2023
@AMollis AMollis added this to the MRTK 2.x future milestone Apr 6, 2023
@AMollis AMollis changed the title Remove com.microsoft.mrtk.windowsspeech strong dependency on com.microsoft.mrtk.tts.windows Remove com.microsoft.mrtk.windowsspeech's strong dependency on com.microsoft.mrtk.tts.windows Apr 6, 2023
@AMollis AMollis self-assigned this Apr 17, 2023
@AMollis AMollis modified the milestones: MRTK 2.x future, MRTK v3.0 GA Apr 17, 2023
@AMollis AMollis modified the milestones: MRTK v3.0 GA, MRTK v3.0 GA+ Apr 28, 2023
@AMollis AMollis assigned AMollis and unassigned AMollis May 12, 2023
@AMollis AMollis removed their assignment Jul 7, 2023
@IssueSyncBot IssueSyncBot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feature request from the community IssueMigrated MRTK3
Projects
None yet
Development

No branches or pull requests

2 participants