Skip to content

Commit

Permalink
Remove failed test changes
Browse files Browse the repository at this point in the history
  • Loading branch information
shaynie committed Jul 25, 2023
1 parent 02b33da commit e5800b5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,25 +72,11 @@ private void OnDisable()
ReticleSetActive(false);
}

/// <summary>
/// A Unity event function that is called every frame, if this object is enabled.
/// </summary>
//private void LateUpdate()
//{
// // if running in batch mode the onBeforeRender event doesn't fire so
// // we need to update the reticle here
// if (Application.isBatchMode)
// {
// UpdateReticle();
// }
//}

private static readonly ProfilerMarker UpdateReticlePerfMarker = new ProfilerMarker("[MRTK] MRTKRayReticleVisual.UpdateReticle");

[BeforeRenderOrder(XRInteractionUpdateOrder.k_BeforeRenderLineVisual)]
private void UpdateReticle()
{
Debug.Log("UpdateReticle");
using (UpdateReticlePerfMarker.Auto())
{
if (Reticle != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,6 @@ public IEnumerator TestManipulationCursor([ValueSource(nameof(BoundsVisualsPrefa
yield return HoverCursorRotation("RotateHandle (5)", new Vector3(0f, 180f, 90f), visualsPath);
// Known side rotate handle
yield return HoverCursorRotation("RotateHandle (10)", new Vector3(0f, 180f, 0f), visualsPath);

}

private bool ApproximatelyEquals(Vector3 a, Vector3 b, float tolerance = 0.1f)
Expand Down Expand Up @@ -372,7 +371,7 @@ private IEnumerator HoverCursorRotation(string handleName, Vector3 expectedRotat
// Move it so the far ray hovers the handle
Assert.IsNotNull(handle);
yield return hand.AimAt(handle.transform.position);
yield return RuntimeTestUtilities.WaitForUpdates(frameCount:60);
yield return RuntimeTestUtilities.WaitForUpdates();

Assert.IsTrue(handle.isHovered, $"Handle should be hovered for {handleName}.");
SpatialManipulationReticle[] reticles = Object.FindObjectsOfType<SpatialManipulationReticle>();
Expand Down

0 comments on commit e5800b5

Please sign in to comment.