Skip to content

Commit 580dcef

Browse files
author
Werner Henze
committed
Fix gcc build problem
Closes issue #1148 by fixing problems introduced in PR #1140.
1 parent b39e7e4 commit 580dcef

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

include/gsl/span

+8-4
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,12 @@
6464
#endif
6565

6666
// Turn off clang unsafe buffer warnings as all accessed are guarded by runtime checks
67-
#if defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
67+
#if defined(__clang__)
68+
#if __has_warning("-Wunsafe-buffer-usage")
6869
#pragma clang diagnostic push
6970
#pragma clang diagnostic ignored "-Wunsafe-buffer-usage"
70-
#endif // defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
71+
#endif // __has_warning("-Wunsafe-buffer-usage")
72+
#endif // defined(__clang__)
7173

7274
namespace gsl
7375
{
@@ -852,8 +854,10 @@ as_writable_bytes(span<ElementType, Extent> s) noexcept
852854
#pragma GCC diagnostic pop
853855
#endif // __GNUC__ > 6
854856

855-
#if defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
857+
#if defined(__clang__)
858+
#if __has_warning("-Wunsafe-buffer-usage")
856859
#pragma clang diagnostic pop
857-
#endif
860+
#endif // __has_warning("-Wunsafe-buffer-usage")
861+
#endif // defined(__clang__)
858862

859863
#endif // GSL_SPAN_H

include/gsl/util

+8-4
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,12 @@
4141
#endif // _MSC_VER
4242

4343
// Turn off clang unsafe buffer warnings as all accessed are guarded by runtime checks
44-
#if defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
44+
#if defined(__clang__)
45+
#if __has_warning("-Wunsafe-buffer-usage")
4546
#pragma clang diagnostic push
4647
#pragma clang diagnostic ignored "-Wunsafe-buffer-usage"
47-
#endif // defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
48+
#endif // __has_warning("-Wunsafe-buffer-usage")
49+
#endif // defined(__clang__)
4850

4951
#if defined(__cplusplus) && (__cplusplus >= 201703L)
5052
#define GSL_NODISCARD [[nodiscard]]
@@ -160,8 +162,10 @@ constexpr auto at(std::span<T, extent> sp, const index i) -> decltype(sp[sp.size
160162

161163
#endif // _MSC_VER
162164

163-
#if defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
165+
#if defined(__clang__)
166+
#if __has_warning("-Wunsafe-buffer-usage")
164167
#pragma clang diagnostic pop
165-
#endif
168+
#endif // __has_warning("-Wunsafe-buffer-usage")
169+
#endif // defined(__clang__)
166170

167171
#endif // GSL_UTIL_H

0 commit comments

Comments
 (0)