-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scan All Workspace Files Command to DevSkim VS Code #564
Comments
The Microsoft Sarif Viewer has an extension-to-extension api that would be great as an addition to this feature; https://code.visualstudio.com/api/references/vscode-api#extensions |
Hey @martijn-coolminds can you elaborate a bit more on the integration you'd like to see with the SARIF Viewer Extension? Is it that you'd want to run a full scan of all files in the workspace, output a sarif and have it open in the SARIF Viewer (if also installed)? |
Yeah, exactly that! The plugin allows for inter plugin communication. I'm under the impression that it would allow to send the results directly to the sarif viewer. |
I'll see if I can take a look into that possibility - the linked NuGet for full Visual Studio I believe, but it looks like this is also possible with the VS Code version as long as the sarif log is written to a file on disk first: https://github.com/Microsoft/sarif-vscode-extension?tab=readme-ov-file#api. I think that would be something neat to potentially add onto the end of this feature, but this issue first requires some other changes first to be able to enumerate + scan all the files in the workspace. I'm not yet sure when I'll be able to revisit this but I think the overall change that would support opening as a sarif log would require something like the following:
|
Is your feature request related to a problem? Please describe.
Previous versions of the DevSkim VS Code Extension had a palette command to trigger a scan of all files in the workspace. This was removed with 1.0 due to the new Language Server mechanism, which meant we weren't directly dealing with file paths on disk anymore. We've received some user feedback #555 that this feature should be brought back.
Describe the solution you'd like
Reimplement the Scan All Files in Workspace command
The text was updated successfully, but these errors were encountered: