Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQUEST] FPDT backward test #6955

Open
YizhouZ opened this issue Jan 16, 2025 · 2 comments
Open

[REQUEST] FPDT backward test #6955

YizhouZ opened this issue Jan 16, 2025 · 2 comments
Assignees
@loadams
Labels
enhancement New feature or request

Comments

@YizhouZ
Copy link
Contributor

YizhouZ commented Jan 16, 2025

Hi, I am testing FPDT feature with unit test under tests/unit/sequence_parallelism/test_ulysses.py. It seems no backward test, only the forward test. Could you please consider adding a backward test? Thanks!
@YizhouZ YizhouZ added the enhancement New feature or request label Jan 16, 2025
@loadams loadams assigned loadams and unassigned loadams Jan 16, 2025
@YJHMITWEB
Copy link
Collaborator

Thanks @YizhouZ , will add the backward test recently.

@loadams
Copy link
Contributor

loadams commented Jan 17, 2025

Thanks @YizhouZ - let us know when you have the PR ready.

@loadams loadams self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loadams loadams

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@YJHMITWEB @YizhouZ @loadams