Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genericise Windows VM post install script to deal with different R versions #4289

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Jan 29, 2025

Resolves #4288

What is being addressed

See #4288

@jonnyry jonnyry requested a review from marrobi January 29, 2025 12:42
Copy link

github-actions bot commented Jan 29, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0ba3a06.

♻️ This comment has been updated with latest results.

@jonnyry jonnyry requested a review from tamirkamara January 29, 2025 12:44
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing you have tested it, LGTM.

@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 5, 2025

/test-force-approve

not covered by CI test, tested locally

Copy link

github-actions bot commented Feb 5, 2025

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 0ba3a06)

(in response to this comment from @jonnyry)

@jonnyry jonnyry merged commit 8103f96 into microsoft:main Feb 5, 2025
12 checks passed
@jonnyry jonnyry deleted the jr/upstream-main/90-r-package-mirror branch February 5, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows R version must be 4.1.2 otherwise post install script doesn't update package mirror URL
3 participants