Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable local authentication between Airlock Processor and Azure Service Bus in Function Binding #4277

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Disable local authentication between Airlock Processor and Azure Service Bus in Function Binding #4277

wants to merge 8 commits into from

Conversation

guybartal
Copy link
Collaborator

Resolves #4259

What is being addressed

Customers may want to disable local auth between azure functions and
service bus queues, this PR sets the requiered environment variables for Azure Function bindings in Airlock Processor module.

How is this addressed

@guybartal
Copy link
Collaborator Author

/help

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

Hello!

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @guybartal)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2025 •
edited
Loading

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7ad89d4.

♻️ This comment has been updated with latest results.

@guybartal guybartal changed the title Guybartal/airlock-disable-local-auth-for-sb Disable local authentication between Airlock Processor and Azure Service Bus in Function Binding Jan 19, 2025
@guybartal
Copy link
Collaborator Author

/test

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12854924727 (with refid 07c0773e)

(in response to this comment from @guybartal)

tamirkamara
tamirkamara reviewed Jan 19, 2025
View reviewed changes
core/terraform/airlock/airlock_processor.tf Outdated Show resolved Hide resolved
airlock_processor/host.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara Awaiting requested review from tamirkamara

@yuvalyaron yuvalyaron Awaiting requested review from yuvalyaron

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable local authentication in ServiceBus
2 participants
@guybartal @tamirkamara