Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make netty http client resilient to not being closed #676

Open
yawkat opened this issue Aug 17, 2023 · 0 comments
Open

Make netty http client resilient to not being closed #676

yawkat opened this issue Aug 17, 2023 · 0 comments

Comments

@yawkat
Copy link
Member

yawkat commented Aug 17, 2023

Issue description

The netty implementation of HttpClient starts a netty thread pool. If the client isn't closed, that pool stays alive indefinitely and prevents automatic application shutdown. If we make the pool use daemon threads instead, this might be fixed.

A caveat is connection pooling, not sure how an alive pooled connection would interact with daemon thread shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant