work on test coverage

Author: Ben Roberts

.gitignore

@@ -32,3 +32,6 @@ Gemfile.lock
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
 .rvmrc
+
+#vim files being edited
+*.swp

lib/microformats/results/parser_result.rb

@@ -20,7 +20,7 @@ def to_json
     def to_s
       return @hash['value'] if @hash['value']
 
-      super
+      @hash.to_s
     end
 
     def [](key)

lib/microformats/results/property_set.rb

@@ -21,6 +21,10 @@ def [](key)
       @hash[key]
     end
 
+    def to_s
+      @hash.to_s
+    end
+
     def respond_to?(sym, include_private = false)
       key?(sym) || super(sym, include_private)
     end

spec/lib/microformats/collection_spec.rb

@@ -0,0 +1,57 @@
+describe Microformats::Collection do
+  let(:parser) { Microformats::Parser.new }
+
+
+    describe "collection to hash or string" do
+      before do
+        @html = '<div class="h-card"><p class="p-name">Jessica Lynn Suttles</p></div>'
+        @html.freeze
+      end
+
+      it "is accessible as a hash []" do
+          expect(Microformats.parse(@html)['items'][0]['properties']['name'][0]).to eq("Jessica Lynn Suttles")
+      end
+      it "can convert to hash" do
+          expect(Microformats.parse(@html).to_hash['items'][0]['properties']['name'][0]).to eq("Jessica Lynn Suttles")
+      end
+      it "can convert to hash by to_h" do
+          expect(Microformats.parse(@html).to_h['items'][0]['properties']['name'][0]).to eq("Jessica Lynn Suttles")
+      end
+      it "converts to string" do
+          expect(Microformats.parse(@html).to_s).to eq("{\"items\"=>[{\"type\"=>[\"h-card\"], \"properties\"=>{\"name\"=>[\"Jessica Lynn Suttles\"]}}], \"rels\"=>{}, \"rel-urls\"=>{}}")
+      end
+    end
+
+    describe "collection functions" do
+      before do
+        @html = '<div class="h-card"><p class="p-name">Jessica Lynn Suttles</p><a rel="canonical" class="u-url" href="https://example.com/">homepage</a></div><div class="h-as-sample"><p class="p-name">sample</p></div>'
+        @html.freeze
+      end
+
+      it "is has rels function" do
+          expect(Microformats.parse(@html).rels['canonical'][0]).to eq('https://example.com/')
+      end
+
+      it "is has rel_urls function" do
+          expect(Microformats.parse(@html).rel_urls['https://example.com/']['rels'][0]).to eq('canonical')
+      end
+
+      it "has respond_to? function" do
+          expect(Microformats.parse(@html)).to respond_to(:respond_to?)
+      end
+
+      it "supports old parser function calls by h- name" do
+          expect(Microformats.parse(@html).card.to_hash).to eq(Microformats.parse(@html).items[0].to_hash)
+          expect(Microformats.parse(@html).card(:all)[0].to_hash).to eq(Microformats.parse(@html).items[0].to_hash)
+          expect(Microformats.parse(@html).card(0).to_hash).to eq(Microformats.parse(@html).items[0].to_hash)
+          expect(Microformats.parse(@html).card(3).to_hash).to eq(Microformats.parse(@html).items[0].to_hash)
+          expect(Microformats.parse(@html).as_sample.to_hash).to eq(Microformats.parse(@html).items[1].to_hash)
+      end
+
+      it "has an items function that returns an array of ParserResult objects" do
+          expect(Microformats.parse(@html).items[0]).to be_kind_of Microformats::ParserResult
+      end
+
+    end
+
+end

spec/lib/microformats/parser_result_spec.rb

@@ -0,0 +1,51 @@
+describe Microformats::ParserResult do
+  let(:parser) { Microformats::Parser.new }
+
+    describe "conversion functions" do
+      before do
+        @html = '<div class="h-card"><p class="p-name">Jessica Lynn Suttles</p></div>'
+        @html.freeze
+        @item = Microformats.parse(@html).items[0]
+      end
+
+      it "is accessible as a hash []" do
+          expect(@item['properties']['name'][0]).to eq("Jessica Lynn Suttles")
+      end
+      it "can convert to hash" do
+          expect(@item.to_hash['properties']['name'][0]).to eq("Jessica Lynn Suttles")
+      end
+      it "can convert to hash by to_h" do
+          expect(@item.to_h['properties']['name'][0]).to eq("Jessica Lynn Suttles")
+      end
+      it "converts to json" do
+          expect(@item.to_json).to eq("{\"type\":[\"h-card\"],\"properties\":{\"name\":[\"Jessica Lynn Suttles\"]}}")
+      end
+      it "converts to string" do
+          expect(@item.to_s).to eq(@item.to_h.to_s)
+      end
+    end
+
+    describe "parser result functions" do
+      before do
+        @html = '<div class="h-card"><p class="p-name">Jessica Lynn Suttles</p><a rel="canonical" class="u-url u-like-of" href="https://example.com/">homepage</a></div>'
+        @html.freeze
+        @item = Microformats.parse(@html).items[0]
+      end
+
+      it "has respond_to? function" do
+          expect(@item).to respond_to(:respond_to?)
+      end
+
+      it "returns PropertySets" do
+          expect(@item.properties).to be_kind_of Microformats::PropertySet
+      end
+
+      it "supports old parser function calls by property name" do
+          expect(@item.name).to eq("Jessica Lynn Suttles")
+          expect(@item.url).to eq("https://example.com/")
+          expect(@item.like_of).to eq("https://example.com/")
+      end
+    end
+
+
+end

spec/lib/microformats/parser_spec.rb

@@ -81,57 +81,6 @@
     end
   end
 
-  describe "#paser_results_classes" do
-
-    describe "collection to hash or string" do
-      before do
-        @html = '<div class="h-card"><p class="p-name">Jessica Lynn Suttles</p></div>'
-        @html.freeze
-      end
-
-      it "is accessible as a hash []" do
-          expect(Microformats.parse(@html)['items'][0]['properties']['name'][0]).to eq("Jessica Lynn Suttles")
-      end
-      it "can convert to hash" do
-          expect(Microformats.parse(@html).to_hash['items'][0]['properties']['name'][0]).to eq("Jessica Lynn Suttles")
-      end
-      it "can convert to hash by to_h" do
-          expect(Microformats.parse(@html).to_h['items'][0]['properties']['name'][0]).to eq("Jessica Lynn Suttles")
-      end
-      it "converts to string" do
-          expect(Microformats.parse(@html).to_s).to eq("{\"items\"=>[{\"type\"=>[\"h-card\"], \"properties\"=>{\"name\"=>[\"Jessica Lynn Suttles\"]}}], \"rels\"=>{}, \"rel-urls\"=>{}}")
-      end
-    end
-
-    describe "collection functions" do
-      before do
-        @html = '<div class="h-card"><p class="p-name">Jessica Lynn Suttles</p><a rel="canonical" class="u-url" href="https://example.com/">homepage</a></div><div class="h-as-sample"><p class="p-name">sample</p></div>'
-        @html.freeze
-      end
-
-      it "is has rels function" do
-          expect(Microformats.parse(@html).rels['canonical'][0]).to eq('https://example.com/')
-      end
-
-      it "is has rel_urls function" do
-          expect(Microformats.parse(@html).rel_urls['https://example.com/']['rels'][0]).to eq('canonical')
-      end
-
-      it "has respond_to? function" do
-          expect(Microformats.parse(@html)).to respond_to(:respond_to?)
-      end
-
-      it "supports old parser function calls by h- name" do
-          expect(Microformats.parse(@html).card.to_hash).to eq(Microformats.parse(@html).items[0].to_hash)
-          expect(Microformats.parse(@html).card(:all)[0].to_hash).to eq(Microformats.parse(@html).items[0].to_hash)
-          expect(Microformats.parse(@html).card(0).to_hash).to eq(Microformats.parse(@html).items[0].to_hash)
-          expect(Microformats.parse(@html).card(3).to_hash).to eq(Microformats.parse(@html).items[0].to_hash)
-          expect(Microformats.parse(@html).as_sample.to_hash).to eq(Microformats.parse(@html).items[1].to_hash)
-      end
-    end
-  end
-
-
   describe "edge cases" do
     cases_dir = "spec/support/lib/edge_cases/"
     Dir[File.join(cases_dir, "*")].keep_if { |f| f =~ /([.]js$)/ }.each do |json_file|

spec/lib/microformats/property_set_spec.rb

@@ -0,0 +1,28 @@
+describe Microformats::PropertySet do
+  let(:parser) { Microformats::Parser.new }
+
+    describe "conversion functions" do
+      before do
+        @html = '<div class="h-card"><p class="p-name">Jessica Lynn Suttles</p></div>'
+        @html.freeze
+        @set = Microformats.parse(@html).items[0].properties
+      end
+
+      it "is accessible as a hash []" do
+          expect(@set['name'][0]).to eq("Jessica Lynn Suttles")
+      end
+      it "can convert to hash" do
+          expect(@set.to_hash['name'][0]).to eq("Jessica Lynn Suttles")
+      end
+      it "can convert to hash by to_h" do
+          expect(@set.to_h['name'][0]).to eq("Jessica Lynn Suttles")
+      end
+      it "converts to json" do
+          expect(@set.to_json).to eq("{\"name\":[\"Jessica Lynn Suttles\"]}")
+      end
+      it "converts to string" do
+          expect(@set.to_s).to eq(@set.to_h.to_s)
+      end
+    end
+
+end