fix: Handle empty alt for images in implied p-name (#413)

* fix: ignore empty attributes

* test: tests for implied name with empty alt in img

* fix: use impliedTextContent when parsing p-*

Author: benjifs

src/helpers/attributes.ts

@@ -8,7 +8,10 @@ export const getAttribute = (
 export const getAttributeValue = (
   node: Element,
   name: string,
-): string | undefined => getAttribute(node, name)?.value;
+): string | undefined => {
+  const attr = getAttribute(node, name)?.value;
+  return attr?.length ? attr : undefined;
+};
 
 export const getClassNames = (
   node: Element,

src/microformats/property.ts

@@ -16,7 +16,7 @@ import {
 import { isMicroformatRoot } from "../helpers/nodeMatchers";
 import { parseMicroformat } from "./parse";
 import { valueClassPattern } from "../helpers/valueClassPattern";
-import { textContent } from "../helpers/textContent";
+import { textContent, impliedTextContent } from "../helpers/textContent";
 import { parseImage } from "../helpers/images";
 import { isLocalLink, applyBaseUrl } from "../helpers/url";
 import { convertV1PropertyClassNames } from "../backcompat";
@@ -36,7 +36,7 @@ export const parseP = (node: Element, options: ParsingOptions): string =>
   getAttributeIfTag(node, ["data"], "value") ??
   getAttributeIfTag(node, ["img", "area"], "alt") ??
   getAttributeIfTag(node, ["meta"], "content") ??
-  textContent(node, options);
+  impliedTextContent(node, options);
 
 export const parseU = (
   node: Element,

test/suites/local/microformats-v2/implied-name.html

@@ -0,0 +1,4 @@
+<a class="p-author h-card u-url" href="/">
+  Author
+  <img class="u-photo" src="/photo.jpg" alt="" />
+</a>

test/suites/local/microformats-v2/implied-name.json

@@ -0,0 +1,13 @@
+{
+  "rels": {},
+  "rel-urls": {},
+  "items": [
+    {
+      "type": ["h-card"],
+      "properties": {
+        "photo": ["http://example.com/photo.jpg"],
+        "name": ["Author"]
+      }
+    }
+  ]
+}