Skip to content

Commit a94e53d

Browse files
jaustindpgeorge
authored andcommitted
codal_port: Update P9 to be UNUSED on V2 (was shared on V1).
P9 is a spare pin on micro:bit V2, but was shared with the display on V1. This commit updates the definition of the pin and stops the display from trying to acquire/release it during enable/disable. Full pinout is available https://tech.microbit.org/hardware/edgeconnector/ See #57
1 parent ab8cff4 commit a94e53d

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/codal_port/microbit_display.c

-2
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ mp_obj_t microbit_display_on_func(mp_obj_t self_in) {
128128
microbit_obj_pin_acquire(&microbit_p4_obj, microbit_pin_mode_display);
129129
microbit_obj_pin_acquire(&microbit_p6_obj, microbit_pin_mode_display);
130130
microbit_obj_pin_acquire(&microbit_p7_obj, microbit_pin_mode_display);
131-
microbit_obj_pin_acquire(&microbit_p9_obj, microbit_pin_mode_display);
132131
microbit_obj_pin_acquire(&microbit_p10_obj, microbit_pin_mode_display);
133132
microbit_display_init();
134133
self->active = true;
@@ -145,7 +144,6 @@ mp_obj_t microbit_display_off_func(mp_obj_t self_in) {
145144
microbit_obj_pin_free(&microbit_p4_obj);
146145
microbit_obj_pin_free(&microbit_p6_obj);
147146
microbit_obj_pin_free(&microbit_p7_obj);
148-
microbit_obj_pin_free(&microbit_p9_obj);
149147
microbit_obj_pin_free(&microbit_p10_obj);
150148
return mp_const_none;
151149
}

src/codal_port/microbit_pin.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const microbit_pin_obj_t microbit_p5_obj = {{&microbit_dig_pin_type}, 5, MICR
3737
const microbit_pin_obj_t microbit_p6_obj = {{&microbit_dig_pin_type}, 6, MICROBIT_HAL_PIN_P6, MODE_DISPLAY};
3838
const microbit_pin_obj_t microbit_p7_obj = {{&microbit_dig_pin_type}, 7, MICROBIT_HAL_PIN_P7, MODE_DISPLAY};
3939
const microbit_pin_obj_t microbit_p8_obj = {{&microbit_dig_pin_type}, 8, MICROBIT_HAL_PIN_P8, MODE_UNUSED};
40-
const microbit_pin_obj_t microbit_p9_obj = {{&microbit_dig_pin_type}, 9, MICROBIT_HAL_PIN_P9, MODE_DISPLAY};
40+
const microbit_pin_obj_t microbit_p9_obj = {{&microbit_dig_pin_type}, 9, MICROBIT_HAL_PIN_P9, MODE_UNUSED};
4141
const microbit_pin_obj_t microbit_p10_obj = {{&microbit_ad_pin_type}, 10, MICROBIT_HAL_PIN_P10, MODE_DISPLAY};
4242
const microbit_pin_obj_t microbit_p11_obj = {{&microbit_dig_pin_type}, 11, MICROBIT_HAL_PIN_P11, MODE_BUTTON};
4343
const microbit_pin_obj_t microbit_p12_obj = {{&microbit_dig_pin_type}, 12, MICROBIT_HAL_PIN_P12, MODE_UNUSED};

0 commit comments

Comments
 (0)