Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FluentValidation instead of FluentValidation.AspNetCore #111

Open
cremor opened this issue Jul 5, 2022 · 6 comments
Open

Use FluentValidation instead of FluentValidation.AspNetCore #111

cremor opened this issue Jul 5, 2022 · 6 comments
Labels
investigation In process of investigation

Comments

@cremor
Copy link

cremor commented Jul 5, 2022

Continuation of #97

FluentValidation.AspNetCore support is ending, see FluentValidation/FluentValidation#1959
The workaround mentioned in the readme and in #97 is showing compiler warnings because both IValidatorFactory and ServiceProviderValidatorFactory are marked as obsolete in FluentValidation, see FluentValidation/FluentValidation#1961

I suggest to modify this (very useful!) library to work without FluentValidation.AspNetCore by default.
Until this is done an updated workaround that doesn't raise compiler warnings would be great.
@petriashev petriashev added the investigation In process of investigation label Jul 5, 2022
@petriashev
Copy link
Member

Yes I heard about these changes. Will try to adapt code for new DI needs.

@petriashev
Copy link
Member

Please check 6.0.0-beta.1

@cremor
Copy link
Author

cremor commented Jul 25, 2022

6.0.0-beta.1 seems to work fine, thanks.

@BenasB BenasB mentioned this issue Nov 19, 2022
Merged
@cremor
Copy link
Author

cremor commented Jul 18, 2023

@petriashev When will v6 be released?

@cremor cremor mentioned this issue Aug 4, 2023
Open
@petriashev
Copy link
Member

@petriashev When will v6 be released?

I was on vacation and before that was busy on 140%.
It's not my main project. Ping me sometime!

@lonix1
Copy link
Contributor

lonix1 commented Sep 26, 2023

Beta seems ok.
Let us know if we can help somehow to push it to v6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigation In process of investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cremor @petriashev @lonix1