Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory SRAM mirror tests write to OAM, causing subsequent runs to have failures on hardware. #17

Open
alyosha-tas opened this issue Jul 31, 2022 · 2 comments

Comments

@alyosha-tas
Copy link

DMA0 source/destination address of 0xF000 gets truncated down to 0x7000 so the SRAM mirror store tests write to OAM. This is fine on the first run as the store tests happen after the load test. However subsequent runs of the memory tests will show fails since the SRAM mirror load tests load from OAM, which is no longer 0 as expected as OAM is not cleared in between tests.

Confirmed this happens on hardware (Gameboy Player.)

@endrift
Copy link
Member

endrift commented Jul 31, 2022

Is this what's causing that error? I had trouble narrowing it down.

@alyosha-tas
Copy link
Author

It seems mGBA does not write to OAM in this case, which is probably why it was hard to track down.

There seems to be a few other issues similar to this one, haven't figured out the details yet though.

(Great test suite by the way, it does a lot of cool stuff.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants