Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last.txt is updated when it shouldn't so that videos get skipped #7

Open
T-vK opened this issue Mar 11, 2018 · 1 comment
Open

last.txt is updated when it shouldn't so that videos get skipped #7

T-vK opened this issue Mar 11, 2018 · 1 comment

Comments

@T-vK
Copy link

T-vK commented Mar 11, 2018

I am running your script once per hour automatically in the background. And I noticed again and again, that lots of videos are missing.
Apparently the issue is that the last.txt get's updated even when the server could not be reached (e.g. no Internet connection).
So when I'm somewhere where I don't have have Internet or where it's very unstable (like on a train for instance), it just updates the last.txt to the current timestamp without downloading any of the new videos and thus a lot of new videos will never be downloaded...

I'm not really a Python guy, but it would seem that a simple if statement checking if any new videos have been found before writing to the last.txt would fix this bug.

Edit:
It also seems that videos get skipped when a new video is released while other videos are still being downloaded.. I'm not 100% certain about that, though. I only know that videos sometimes get skipped even when I have an Internet connection.

@seler
Copy link

seler commented May 28, 2018

It might be due to videos appearing in rss with slight delay not at their publication date. The solution would be to store ids of videos that were already downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants