Cover local-change case in diffQced error message

[toddyoder]

It seems like diffQced() throws an error if the local copy of the file does not match the repo's. The error message is

Error in review::diffQced("myscript.R") : 
  Please svn up 'myscript.R' before running comparison

This message is useful if the repo has changed, but the message is misleading if the local copy has been edited. In the latter case a recommendation to revert the file may be helpful.

Version: 3.12.0.9000

[michaelmcd18]

@toddyoder What point in the workflow does this normally come up? Is it when you are a QCer and have already started adding comments to the file?

[toddyoder]

@michaelmcd18 yes, what you described is when I have encountered this situation.

[michaelmcd18]

@toddyoder gotcha, I'm not sure if we'd want to recommend they revert it (as to not get rid of their comments). We could update the message, but it'd be hard for the function to distinguish between the cases...

Just confirming though, functionally everything is working as you'd expect (and want)? It's just the message you're suggesting gets updated?

[toddyoder]

@michaelmcd18 yeah agreed, reverting is probably not the appropriate suggestion.

Yes, everything functionally worked as I expected. It merely took me a while to figure out what was causing diffQced to fail;
the current error message confused me because it recommends svn up, which doesn't do anything when the changes are local, so I continued getting the error after svn up. Maybe the error could be something like this?

"The local copy of 'myscript.R' is out of sync with the repo. Please svn up or check the local copy for changes."