[BUG] Stale files in the math/torsten subtree

[kyleam]

My understanding is that the cmdstan/stan/lib/stan_math/stan/math/torsten subtree of the main Torsten repo should be identical to a top-level tree at https://github.com/metrumresearchgroup/torsten_math.

This is not the case:

$ git -C Torsten rev-parse v0.91.2:cmdstan/stan/lib/stan_math/stan/math/torsten
ed3a6516a991bd3d1332704754b2d3bd0421f034
# That tree does not exist in torsten_math
$ git -C torsten_math rev-parse --verify --quiet ed3a6516a991bd3d1332704754b2d3bd0421f034^{tree}
$ echo $?
1

Here are the file-level differences between the v0.91.2 math/torsten subtree and the latest top-level tree in the torsten_math repo:

$ git -C Torsten rev-parse v0.91.2
4c6640d62912197982a90c0f615aee123f9e70bc

$ git -C torsten_math rev-parse develop
adb89a8f72da0e700d69c966ec03358615fd875c

# the above commit matches the last submodule update in metrumresearchgroup/math
$ git -C math rev-parse torsten-develop:stan/math/torsten
adb89a8f72da0e700d69c966ec03358615fd875

$ git -C Torsten ls-tree -r v0.91.2:cmdstan/stan/lib/stan_math/stan/math/torsten >/tmp/torsten-blobs
$ git -C torsten_math ls-tree -r develop >/tmp/tmath-blobs

diff --git a/tmp/tmath-blobs b/tmp/torsten-blobs
index a479017..9e0acdb 100644
--- a/tmp/tmath-blobs
+++ b/tmp/torsten-blobs
@@ -72,6 +72,7 @@
 100644 blob 3b199ab91a9e674024bf4d60ce5b5b0d985ab684   ev_solver.hpp
 100644 blob 99ad06fcbbd31b314b003997d6ed1d008bef9405   event.hpp
 100644 blob aa33d2b6b8be959a9fcbb1a523171b373787d00d   finite_diff_gradient.hpp
+100644 blob a48d2525843728d3a93b9ae2ed7f72fb34b2e6e5   linear_interpolation.hpp
 100644 blob 159a93ceda3c1b9e46f81fc374bb364e8685a536   makefile
 100644 blob 4883707dbcc102db73c61f9a4005143cce96645e   meta.hpp
 100644 blob 6a7bdc97e6383493e6fe33c8bef54e40b7d97dbf   meta/is_eigen_ode.hpp
@@ -165,6 +166,7 @@
 100644 blob fa4fcd1681caeaaa30d0f2ea136ba3624536b9f1   test/unit/expect_matrix_eq.hpp
 100644 blob 8c1fe1b3a2111544d930e549b2181a972d3a20bf   test/unit/expect_near_matrix_eq.hpp
 100644 blob c09e92edc4d65a52f91568532e186f19032e38cc   test/unit/generalOdeModel.R
+100644 blob 8493fcfaca9bae1a6ef089b78010e372268b7483   test/unit/linear_interpolation_test.cpp
 100644 blob 61c55642cef762713dfee77468d880a75461547b   test/unit/linode_typed_finite_diff_test.cpp
 100644 blob c74fa8bda137216a9fe9e2a4c85885c38bdbc2d4   test/unit/linode_typed_overload_test.cpp
 100644 blob 2d2191403e6bec355c5873169baf3adf86c8758b   test/unit/linode_typed_test.cpp
@@ -235,6 +237,7 @@
 100644 blob 0241405a4960a6615b6eae9d3ee6797eea04b4c2   test/unit/twocpt_typed_finite_diff_test.cpp
 100644 blob 6a348eb4f4aa26a6812cf5fc29e9eed2cfb0ad37   test/unit/twocpt_typed_overload_test.cpp
 100644 blob 06590f086b2d3e7d8e4de8e00101a957a46b0569   test/unit/twocpt_typed_test.cpp
+100644 blob 12c3c5ff9d897e070ca4b9ce88518fc04b701000   test/unit/univariate_integral_test.cpp
 100644 blob c4d4848761752c415987e8b42727263a1387752a   test/unit/util_PKModelOneCpt.hpp
 100644 blob 08b4382f7ce55c8ccc6bf5249660bb8740595f3d   test/unit/util_generalOdeModel.hpp
 100644 blob 0d4036d0d94e0bf50b493e856f32d1847fb2f836   test/unit/util_mixOdeCptModel.hpp
@@ -245,5 +248,6 @@
 100644 blob 9f0286fd649781e977ce394c4f3145b9df8f5d43   to_var.hpp
 100644 blob 1733f21dea5257faf611fed80b6c7b76617094c9   torsten.hpp
 100644 blob 8b5189c92fc93044fba926e9151538a7b8b571ca   torsten_def.hpp
+100644 blob 6b2687da59e432d138183db30e3b51027da0f8e2   univariate_integral.hpp
 100644 blob f0984f522eb3aa4062d4663a622b3efe537b972a   val_and_grad_nested.hpp
 100644 blob 6d0bf3e272b3d345d36b37f7e1fc1746ec5be436   value_of.hpp

So the cmdstan/stan/lib/stan_math/stan/math/torsten subtree in the main Torsten repository has extra files. These files were renamed/deleted in the torsten_math repository:

• a37c02f (rename linear_interpolate to comply with "pmx_" prefix pattern, 2024-11-09)
• 69f273f (remove univariate integral feature, 2025-02-28)

Those changes must not have been propagated when doing the subtree updates in the main repository.

I'm not aware of any functional problems caused be these extraneous files. I'm just flagging them as something to consider cleaning up whenever there are other changes to release.