Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching for target:"/" returns the full unlimited metric list #48

Open
tilsche opened this issue May 23, 2022 · 1 comment · Fixed by #49
Open

Searching for target:"/" returns the full unlimited metric list #48

tilsche opened this issue May 23, 2022 · 1 comment · Fixed by #49
Labels
bug Something isn't working

Comments

@tilsche
Copy link
Contributor

tilsche commented May 23, 2022

It matches the "regex" criteria and has no limit. We could also discuss whether the regex mode should have a default limit (it currently does not, while the infix-mode has a default limit of 100).
@tilsche tilsche added the bug Something isn't working label May 23, 2022
tilsche added a commit that referenced this issue May 23, 2022
@tilsche
fix: prevent / from enabling unlimited search regex mode
856b717 
fixes #48
@tilsche tilsche mentioned this issue May 23, 2022
Merged
tilsche added a commit that referenced this issue May 23, 2022
@tilsche
fix: prevent / from enabling unlimited search regex mode
3f2aeb4 
fixes #48
@bmario
Copy link
Member

bmario commented May 23, 2022

Nonetheless, having a limit is a good idea.

@bmario bmario reopened this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent / from enabling unlimited search regex mode metricq/metricq-grafana
2 participants
@bmario @tilsche