Skip to content

Commit aedbc17

Browse files
committed
Ruby 1.9.1 compat
1 parent b504941 commit aedbc17

File tree

6 files changed

+16
-12
lines changed

6 files changed

+16
-12
lines changed

Rakefile

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# coding: utf-8
2+
13
require 'rake'
24
require 'rake/testtask'
35
require 'test/helper'

lib/active_record/connection_adapters/mysqlplus_adapter.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
begin
1313
require_library_or_gem('fastthread')
14-
rescue => LoadError
14+
rescue LoadError
1515
$stderr.puts "'gem install fastthread' for better performance"
1616
end
1717

lib/active_record/connection_adapters/mysqlplus_adapter/deferrable/macro.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def find_every_with_defer(options) #:nodoc:
121121
records
122122
end
123123

124-
def preload_deferred_includes( include_associations, options )
124+
def preload_deferred_includes( include_associations, options ) #:nodoc:
125125
options[:defer] ? (Array(include_associations) << :defer) : include_associations
126126
end
127127

lib/active_record/connection_adapters/mysqlplus_adapter/deferrable/result.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def initialize( &deferrable )
1515
# back in on completion.
1616
#
1717
def defer!( deferrable )
18-
@result = Thread.new( deferrable ) do |deferrable|
18+
@result = ::Thread.new( deferrable ) do |deferrable|
1919
begin
2020
deferrable.call
2121
rescue => exception
@@ -38,7 +38,7 @@ def method_missing(*args, &block)
3838
# Re-raise any Exceptions from the background Thread.
3939
#
4040
def validate!
41-
raise @_result if @_result.is_a?( Exception )
41+
raise @_result if @_result.is_a?( ::Exception )
4242
end
4343

4444
end

test/deferrable/macro_test.rb

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
require "#{File.dirname(__FILE__)}/../helper"
2+
23
Mysqlplus::Test.prepare!
34

4-
class MacroTest < ActiveRecord::TestCase
5+
class MacroTest < ActiveSupport::TestCase
56

67
def teardown
78
ActiveRecord::Base.clear_all_connections!
8-
ActiveRecord::Base.establish_connection(Mysqlplus::Test::CONNECTION)
9+
ActiveRecord::Base.establish_connection( Mysqlplus::Test::CONNECTION_SPEC )
910
super
1011
end
1112

test/helper.rb

+7-6
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
require 'rubygems'
2+
require 'mocha'
23
require 'active_support'
34
require 'active_support/test_case'
45
require 'activerecord'
@@ -8,11 +9,11 @@
89
module Mysqlplus
910
class Test
1011

11-
CONNECTION = { :adapter => 'mysqlplus',
12-
:username => 'root',
13-
:database => 'mysql',
14-
:pool => 5,
15-
:warmup => true }
12+
CONNECTION_SPEC = { :adapter => 'mysqlplus',
13+
:username => 'root',
14+
:database => 'mysql',
15+
:pool => 5,
16+
:warmup => true }
1617

1718
MODELS_DIR = "#{File.dirname(__FILE__)}/models".freeze
1819

@@ -46,7 +47,7 @@ def test_files
4647
private
4748

4849
def connect!
49-
::ActiveRecord::Base.establish_connection( CONNECTION )
50+
::ActiveRecord::Base.establish_connection( CONNECTION_SPEC )
5051
end
5152

5253
def require_models

0 commit comments

Comments
 (0)