From ff409d6c8e55529c7ae9e66c566a08263bd0ba6b Mon Sep 17 00:00:00 2001 From: Stanislav Cherviakov Date: Thu, 21 Dec 2023 15:01:19 +0000 Subject: [PATCH 1/4] using required rust version --- .github/workflows/rust.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 158586fec..cd48456f4 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -11,18 +11,19 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Install Rust + - name: Install Rust specific version uses: actions-rs/toolchain@v1 with: - toolchain: stable + toolchain: 1.70.0 profile: minimal + components: clippy, rustfmt override: true - name: Check formatting uses: actions-rs/cargo@v1 with: command: fmt - args: -- --check + args: --all -- --check - name: Lint with Clippy uses: actions-rs/clippy-check@v1 From d52f66f245bd318d8044247f70185cf5220889f8 Mon Sep 17 00:00:00 2001 From: Stanislav Cherviakov Date: Thu, 21 Dec 2023 15:10:07 +0000 Subject: [PATCH 2/4] check the build --- .github/workflows/rust.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index cd48456f4..35a866bce 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -19,18 +19,18 @@ jobs: components: clippy, rustfmt override: true - - name: Check formatting - uses: actions-rs/cargo@v1 - with: - command: fmt - args: --all -- --check - - name: Lint with Clippy uses: actions-rs/clippy-check@v1 with: token: ${{ secrets.GITHUB_TOKEN }} args: -- -D warnings + - name: Check formatting + uses: actions-rs/cargo@v1 + with: + command: fmt + args: --all -- --check + - name: Run tests uses: actions-rs/cargo@v1 with: From b69b43d18deb32b12e188ad1db25fa38da04558a Mon Sep 17 00:00:00 2001 From: Stanislav Cherviakov Date: Thu, 21 Dec 2023 15:20:39 +0000 Subject: [PATCH 3/4] running tests first just as a check --- .github/workflows/rust.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 35a866bce..c8de48924 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -19,6 +19,12 @@ jobs: components: clippy, rustfmt override: true + - name: Run tests + uses: actions-rs/cargo@v1 + with: + command: test + args: --features integration_tests + - name: Lint with Clippy uses: actions-rs/clippy-check@v1 with: @@ -30,9 +36,3 @@ jobs: with: command: fmt args: --all -- --check - - - name: Run tests - uses: actions-rs/cargo@v1 - with: - command: test - args: --features integration_tests From 3d0532025a55b460d03cd370cb37bf7ae1495518 Mon Sep 17 00:00:00 2001 From: Stanislav Cherviakov Date: Thu, 21 Dec 2023 16:28:58 +0000 Subject: [PATCH 4/4] reverted to proper order to fail fast --- .github/workflows/rust.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index c8de48924..cd48456f4 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -19,11 +19,11 @@ jobs: components: clippy, rustfmt override: true - - name: Run tests + - name: Check formatting uses: actions-rs/cargo@v1 with: - command: test - args: --features integration_tests + command: fmt + args: --all -- --check - name: Lint with Clippy uses: actions-rs/clippy-check@v1 @@ -31,8 +31,8 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} args: -- -D warnings - - name: Check formatting + - name: Run tests uses: actions-rs/cargo@v1 with: - command: fmt - args: --all -- --check + command: test + args: --features integration_tests