From f929deb353cd2a59e2aa0a510c9c07c2483b62ad Mon Sep 17 00:00:00 2001
From: Nick Nicholas <opoudjis@gmail.com>
Date: Wed, 8 Jan 2025 08:44:04 +0200
Subject: [PATCH] Presentation XML refactor, terms:
 https://github.com/metanorma/isodoc/issues/630

---
 lib/isodoc/presentation_function/terms.rb |  8 +++++--
 spec/isodoc/terms_spec.rb                 | 27 +++++++++++++++++++++--
 2 files changed, 31 insertions(+), 4 deletions(-)

diff --git a/lib/isodoc/presentation_function/terms.rb b/lib/isodoc/presentation_function/terms.rb
index beee35f0..4eebfe60 100644
--- a/lib/isodoc/presentation_function/terms.rb
+++ b/lib/isodoc/presentation_function/terms.rb
@@ -130,9 +130,13 @@ def termsource_modification(elem)
 
     def termsource_add_modification_text(mod)
       mod or return
-      mod.text.strip.empty? or mod.previous = " &#x2014; "
+      if mod.text.strip.empty?
+        mod.remove
+        return
+      end
+      mod.previous = " &#x2014; "
       mod.elements.size == 1 and mod.children = to_xml(mod.elements[0].children)
-      mod.text.strip.empty? or mod.replace(semx_fmt_dup(mod))
+      mod.replace(semx_fmt_dup(mod))
     end
 
     def termsource_status(status)
diff --git a/spec/isodoc/terms_spec.rb b/spec/isodoc/terms_spec.rb
index 5530259d..aa5eda00 100644
--- a/spec/isodoc/terms_spec.rb
+++ b/spec/isodoc/terms_spec.rb
@@ -136,6 +136,14 @@
             <p id='_'>with adjustments</p>
           </modification>
         </termsource>
+        <termsource status='adapted'>
+          <origin citeas=''>
+            <termref base='IEV' target='xyz'>t1</termref>
+          </origin>
+          <modification>
+            <p id='_'/>
+          </modification>
+        </termsource>
       </term>
       <term id="paddy"><preferred><expression><name>paddy</name></expression></preferred>
       <admitted><letter-symbol><name>paddy rice</name></letter-symbol>
@@ -333,6 +341,14 @@
                          <p original-id="_">with adjustments</p>
                       </modification>
                    </termsource>
+                   <termsource status="adapted" id="_">
+                      <origin citeas="">
+                         <termref base="IEV" target="xyz">t1</termref>
+                      </origin>
+                      <modification>
+                         <p original-id="_"/>
+                      </modification>
+                   </termsource>
                    <fmt-termsource status="identical">
                       [SOURCE:
                       <semx element="termsource" source="_">
@@ -347,6 +363,13 @@
                             <termref base="IEV" target="xyz"/>
                          </origin>
                          , modified — <semx element="modification" source="_">with adjustments</semx>
+               </semx>
+               ;
+               <semx element="termsource" source="_">
+                  <origin citeas="">
+                     <termref base="IEV" target="xyz">t1</termref>
+                  </origin>
+                  , adapted
                       </semx>
                       ]
                    </fmt-termsource>
@@ -568,7 +591,7 @@
                          </ul>
                       </div>
                    </div>
-                   <p>[SOURCE: t1 — comment; Termbase IEV, term ID xyz, modified — with adjustments]</p>
+                   <p>[SOURCE: t1 — comment; Termbase IEV, term ID xyz, modified — with adjustments; t1, adapted]</p>
                    <p class="TermNum" id="paddy">1.2.</p>
                    <p class="Terms" style="text-align:left;">
                       <b>paddy</b>
@@ -648,7 +671,7 @@
                          </ul>
                       </div>
                    </div>
-                   <p>[SOURCE: t1 — comment; Termbase IEV, term ID xyz, modified — with adjustments]</p>
+                   <p>[SOURCE: t1 — comment; Termbase IEV, term ID xyz, modified — with adjustments; t1, adapted]</p>
                    <p class="TermNum" id="paddy">1.2.</p>
                    <p class="Terms" style="text-align:left;">
                       <b>paddy</b>