This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Get latest release and verify SHA-256 hash #6
Merged
aviramha
merged 12 commits into
metalbear-co:main
from
rajivshah3:feature/get-latest-release
Dec 26, 2022
Merged
Get latest release and verify SHA-256 hash #6
aviramha
merged 12 commits into
metalbear-co:main
from
rajivshah3:feature/get-latest-release
Dec 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
commented
Dec 7, 2022
Looks good! Is it draft on purpose or I can merge it? |
@aviramha sorry for the delay in replying! There are two things left imo:
I'll look into the first point but I was wondering what your thoughts are on the second one |
Either approach looks good ;) |
aviramha
approved these changes
Dec 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${{ secrets.GITHUB_TOKEN }}
to avoid issues with rate limitingsccache
SHA-256 hash (closes Verify SHA-256 of downloaded binary #5)