Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Get latest release and verify SHA-256 hash #6

Merged
merged 12 commits into from
Dec 26, 2022

Conversation

rajivshah3
Copy link
Contributor

@rajivshah3 rajivshah3 commented Dec 7, 2022

@aviramha
Copy link
Member

Looks good! Is it draft on purpose or I can merge it?

@rajivshah3
Copy link
Contributor Author

@aviramha sorry for the delay in replying! There are two things left imo:

  • In my own tests I ran into an error that said Error getting latest release: 403 rate limit exceeded. I'm going to see if I can reproduce this. I wonder if a GITHUB_TOKEN needs to be passed to the action?
    • If we need to use a token, the blue "Important" box here makes it sound like we can pick it up without the action user actually passing a token 🤔
  • I don't want to increase the scope of this PR if possible, but I'm wondering how the caching of the sccache binary should be handled. Should we always check if the latest version is in the cache and if not, we download it and cache it? Alternatively we could check the cache for any version greater than or equal to the last known working version and use that
    • If we go with the second approach and a bug arises in the version that's in the cache, should the action user have a way of forcing the action to download and use a specific version of sccache?
    • A side question — is the tool cache only actually used on self-hosted runners? If that's the case I wonder how we can test this behavior if we're using the GitHub-hosted runners 🤔

I'll look into the first point but I was wondering what your thoughts are on the second one

@aviramha
Copy link
Member

Either approach looks good ;)

@rajivshah3 rajivshah3 marked this pull request as ready for review December 21, 2022 21:30
@rajivshah3 rajivshah3 requested a review from aviramha December 21, 2022 21:30
Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@aviramha aviramha merged commit f23787a into metalbear-co:main Dec 26, 2022
@rajivshah3 rajivshah3 deleted the feature/get-latest-release branch December 28, 2022 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify SHA-256 of downloaded binary Download latest release
2 participants