Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yamllint configuration needs improvements #947

Open
tuminoid opened this issue Jan 10, 2025 · 2 comments
Open

Yamllint configuration needs improvements #947

tuminoid opened this issue Jan 10, 2025 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@tuminoid
Copy link
Member

tuminoid commented Jan 10, 2025

Our yamllint config is quite simple and needs improvements. For example, we want to enforce yaml to be linted in k8s way, meaning lists are not indented.

Study the yamllint tool, and its options and decide what is the acceptable level of enforcement. Make the change here in project-infra (as it is the only repo where it is implemented right now), then add the linter to other repos as well.

Some notes to consider:

  • We have manifestlint check in CAPM3/IPAM/IRSO/BMO, which might or might not have options for this too. Check the synergies with that
  • yamllint action is out of date by 3 years, not maintained
  • the tool under yamllint action is maintained, so changing the action might be needed, or changing workflow to prow job
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Jan 10, 2025
@Rozzii
Copy link
Member

Rozzii commented Jan 15, 2025

/triage accepted
/kind feature
/help

@metal3-io-bot
Copy link
Collaborator

@Rozzii:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/kind feature
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants