From fe0994c2b2f25d01dce81b7c4f277d6d8be5c6b9 Mon Sep 17 00:00:00 2001
From: Honigeintopf <ebubekir.ates@outlook.de>
Date: Fri, 8 Nov 2024 10:41:36 +0100
Subject: [PATCH] Adjust test to not use retry on conflict

---
 integration/integration_test.go | 32 ++++++++++++++------------------
 1 file changed, 14 insertions(+), 18 deletions(-)

diff --git a/integration/integration_test.go b/integration/integration_test.go
index 28928a5..cc46940 100644
--- a/integration/integration_test.go
+++ b/integration/integration_test.go
@@ -15,7 +15,6 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/client-go/util/retry"
 
 	testcommon "github.com/metal-stack/firewall-controller-manager/integration/common"
 
@@ -1962,13 +1961,13 @@ var _ = Context("integration test", Ordered, func() {
 				return len(firewallList.Items)
 			}, 15*time.Second, interval).Should(BeNumerically(">", 0), "Should have at least one firewall")
 
-			Eventually(func() bool {
+			Eventually(func() error {
 				for _, item := range firewallList.Items {
 					var fw v2.Firewall
 					err := k8sClient.Get(ctx, client.ObjectKeyFromObject(&item), &fw)
 					if err != nil {
 						fmt.Printf("Failed to get firewall: %v\n", err)
-						return false
+						return err
 					}
 
 					if fw.Status.ControllerStatus == nil {
@@ -1976,25 +1975,22 @@ var _ = Context("integration test", Ordered, func() {
 					}
 					//add a fake concile so the unhealty firewall gets deleted
 					fw.Status.ControllerStatus.SeedUpdated.Time = time.Now().Add(-20 * 24 * time.Hour)
-					err = retry.RetryOnConflict(retry.DefaultRetry, func() error {
-						if err := k8sClient.Get(ctx, client.ObjectKeyFromObject(&fw), &fw); err != nil {
-							return err
-						}
-						if fw.Status.ControllerStatus == nil {
-							fw.Status.ControllerStatus = &v2.ControllerConnection{}
-						}
-						fw.Status.ControllerStatus.SeedUpdated.Time = time.Now().Add(-20 * 24 * time.Hour)
-						return k8sClient.Status().Update(ctx, &fw)
-					})
-
+					if err := k8sClient.Get(ctx, client.ObjectKeyFromObject(&fw), &fw); err != nil {
+						return err
+					}
+					if fw.Status.ControllerStatus == nil {
+						fw.Status.ControllerStatus = &v2.ControllerConnection{}
+					}
+					fw.Status.ControllerStatus.SeedUpdated.Time = time.Now().Add(-20 * 24 * time.Hour)
+					err = k8sClient.Status().Update(ctx, &fw)
 					if err != nil {
 						fmt.Printf("Failed to update firewall status: %v\n", err)
-						return false
+						return err
 					}
-
 				}
-				return true
-			}, 10*time.Second, interval).Should(BeTrue(), "All Firewalls should be deleted")
+
+				return nil
+			}, 10*time.Second, interval).Should(Succeed(), "All Firewalls should be deleted")
 
 			By("verifying that a new firewall has been created")
 			Eventually(func() int {