Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the mobile UI for WIMP #90

Open
3 tasks
uday-kalyan-s opened this issue Oct 13, 2024 · 7 comments
Open
3 tasks

modify the mobile UI for WIMP #90

uday-kalyan-s opened this issue Oct 13, 2024 · 7 comments

Comments

@uday-kalyan-s
Copy link

uday-kalyan-s commented Oct 13, 2024

discussions

evident bugs

  • the fixed and small size of search bar causes an overflow of text. especially the search bar my PR fixes this by increasing the width to 80%.
    However i believe a varying size input may be better for smaller names (see "Arun Ghosh") keeping a min if 45% and a max of 90%
  • large prof names ("Arun Kumar Samantaray") pushes the dept to the far right making a huge gap
    splitting this such that 20% of the space goes to the dept code might fix the issue
  • huge margin in the timetable on right side

suggestions

  • small doodle art.
    this is hardly even visible but removing it might make the page seem really dull and text-ish. I honestly don't know how to accommodate for it.
  • dark mode(i could move this to a new issue as it is irrespective of the Layout but I am keeping this here for now)

tasks

  • fix search bar
  • fix prof name display
  • fix table margin

Also I would love to take up the issue myself. I will make a proper PR for it soon

requesting for disc @Prasanthi-Peram @Dami-18

@uday-kalyan-s uday-kalyan-s changed the title mofidy the mobile UI for WIMP modify the mobile UI for WIMP Oct 13, 2024
@Dami-18
Copy link
Contributor

Dami-18 commented Oct 13, 2024

Initially the project was made keeping by minimal frontend and not being focused on design and responsiveness. So frontend needs some changes as you mentioned

@Dami-18
Copy link
Contributor

Dami-18 commented Oct 13, 2024

As for the layout and design, you will need to try out some things and then see which is better. So you can go ahead with your proposed changes and try some things out like maybe changing margins, padding, responsive font sizes, etc.

@Dami-18
Copy link
Contributor

Dami-18 commented Oct 13, 2024

@harshkhandeparkar what are your opinions on this?

@Dami-18
Copy link
Contributor

Dami-18 commented Oct 14, 2024

cc: @rohan-b-84

@harshkhandeparkar
Copy link
Member

Ah I missed this issue. I commented on the PR first.

@uday-kalyan-s if you have any proposed solution, you can send screenshots and we can discuss here or on Slack #projects.

@uday-kalyan-s
Copy link
Author

@uday-kalyan-s if you have any proposed solution, you can send screenshots and we can discuss here or on Slack #projects.

well my issue mostly revolved around fixing the bugs that were observed on Firefox. now that we realised it's a bigger issue on chrome, I might have to modify the issue again. But like you mentioned in slack, idk how to debug it exactly. I'm not sure about the difference taken in chrome and Firefox here. ig we can discuss it in slack?

@harshkhandeparkar
Copy link
Member

@uday-kalyan-s if you have any proposed solution, you can send screenshots and we can discuss here or on Slack #projects.

well my issue mostly revolved around fixing the bugs that were observed on Firefox. now that we realised it's a bigger issue on chrome, I might have to modify the issue again. But like you mentioned in slack, idk how to debug it exactly. I'm not sure about the difference taken in chrome and Firefox here. ig we can discuss it in slack?

We can resolve the Chrome issue separately. Let's discuss that on Slack. For now, you can work with devtools responsive mode or on Firefox mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants