Skip to content

Commit 9ed5d4e

Browse files
blackwinterblackwinter
committed
Update metafacture-fix issue references after transfer. (#577)
1 parent a6b3d14 commit 9ed5d4e

File tree

40 files changed

+92
-98
lines changed
  • metafacture-commons/src/test/java/org/metafacture/commons
  • metafacture-formeta/src/test/java/org/metafacture/formeta/formatter
  • metafix/src/test
    • java/org/metafacture/metafix
    • resources/org/metafacture/metafix/integration
      • bind/fromJson/toJson
        • listSimpleArrayOfStringsWithVariableAndAppend
        • listSimpleArrayOfStringsWithoutVariableAndAppend
      • lookup/fromJson/toJson/lookupInSubfieldInArrayOfObjects_complex_2_withNotMatchingValue
      • method
        • fromJson/toJson
          • replace_allInArrayOfStringsWithDoList
          • reverseSubfieldInArrayOfObjects
          • reverseValuesInArrayOfStrings
          • sort_fieldInArrayOfObjectsWithAsterisk
          • split_fieldSubfieldInArrayOfObjectsWithAsterisk
          • sumSubfieldInArrayOfObjects
          • uniqMultipleArraysWithAsterisk
          • upcaseInArrayOfStringsWithDoList
        • fromXml/toJson/replace_toUpper
      • record/fromJson/toJson
        • copy_fieldArrayOfObjectsAndListNewArrayOfObjectsAndMoveSubfield
        • copy_fieldArrayOfObjectsAsRepeatedObjectAndThenArrayOfStringsIntoTheArrayOfObjectsWithLastWildcard
        • copy_fieldArrayOfStringsIntoArrayOfObjectsWithAsteriskWildcard
        • copy_fieldArrayOfStringsWithSingleValueAsIndexedRepeatedField
        • copy_fieldArrayWithoutValues
        • copy_fieldValuesOfArrayOfStringsIntoArray
        • copy_fieldWithAlternationOfFieldInArrayOfObjects
        • copy_fieldWithAlternationOfFieldInMultipleArraysOfObjects
        • copy_fieldWithAlternationOfNestedFields
        • move_fieldArrayWithoutValue
        • move_fieldIntoOwnSubfield
        • move_fieldSimpleWithAsteriskPathWildcard
        • move_fieldSimpleWithLeadingQuestionmarkPathWildcard
        • move_fieldSimpleWithTrailingAsteriskPathWildcard
        • move_fieldWithAlternationOfFieldInArrayOfObjects
        • move_fieldWithAlternationOfFieldInMultipleArraysOfObjects
        • move_fieldWithAlternationOfNestedFields
        • remove_fieldArrayOfObjectsInArrayOfObjects
        • remove_fieldAsteriskInArrayOfObjects
        • set_arrayWithoutValuesAndMove_fieldNewArrayOfStringsIntoArrayOfObjects

40 files changed

+92
-98
lines changed

‎metafacture-commons/src/test/java/org/metafacture/commons/XmlUtilTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,8 @@ public void escape_shouldEscapeAllNonAsciiChars() {
5454
assertEquals("København", result);
5555
}
5656

57-
/**
58-
* Test for <a href="https://github.com/culturegraph/metafacture-core/issues/267">#267</a>.
59-
*/
6057
@Test
61-
public void escape_shouldEscapeSurrogatePairsAsSingleEntity() {
58+
public void issue267_escape_shouldEscapeSurrogatePairsAsSingleEntity() {
6259
final String unescaped = "Smile: \ud83d\ude09";
6360
final String result = XmlUtil.escape(unescaped);
6461

‎metafacture-formeta/src/test/java/org/metafacture/formeta/formatter/AbstactFormatterTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@ protected boolean shouldQuoteText(final char[] buffer, final int len) {
5252
};
5353
}
5454

55-
/*
56-
* Test for issue https://github.com/culturegraph/metafacture-core/issues/161
57-
*/
5855
@Test
5956
public void issue161() {
6057
final String longValue = StringUtil.repeatChars('a', AbstractFormatter.BUFFER_SIZE * 2 + 1);

‎metafix/src/test/java/org/metafacture/metafix/MetafixBindTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -697,19 +697,19 @@ public void shouldIterateOverList() {
697697
}
698698

699699
@Test
700-
// See https://github.com/metafacture/metafacture-fix/issues/119
700+
// See issue metafacture-fix#119
701701
public void shouldIterateOverListWithCharacterClass() {
702702
shouldIterateOverList("n[ao]me", 3);
703703
}
704704

705705
@Test
706-
// See https://github.com/metafacture/metafacture-fix/issues/119
706+
// See issue metafacture-fix#119
707707
public void shouldIterateOverListWithAlternation() {
708708
shouldIterateOverList("name|nome", 3);
709709
}
710710

711711
@Test
712-
// See https://github.com/metafacture/metafacture-fix/issues/119
712+
// See issue metafacture-fix#119
713713
public void shouldIterateOverListWithWildcard() {
714714
shouldIterateOverList("n?me", 3);
715715
}
@@ -749,26 +749,26 @@ public void shouldIterateOverListOfHashes() {
749749
}
750750

751751
@Test
752-
// See https://github.com/metafacture/metafacture-fix/issues/119
752+
// See issue metafacture-fix#119
753753
public void shouldIterateOverListOfHashesWithCharacterClass() {
754754
shouldIterateOverListOfHashes("n[ao]me.value", 3);
755755
}
756756

757757
@Test
758-
// See https://github.com/metafacture/metafacture-fix/issues/119
759-
@MetafixToDo("See https://github.com/metafacture/metafacture-fix/issues/143")
758+
// See issue metafacture-fix#119
759+
@MetafixToDo("See issue #603")
760760
public void shouldIterateOverListOfHashesWithAlternation() {
761761
shouldIterateOverListOfHashes("name.value|nome.value", 3);
762762
}
763763

764764
@Test
765-
// See https://github.com/metafacture/metafacture-fix/issues/119
765+
// See issue metafacture-fix#119
766766
public void shouldIterateOverListOfHashesWithWildcard() {
767767
shouldIterateOverListOfHashes("n?me.value", 3);
768768
}
769769

770770
@Test // checkstyle-disable-line JavaNCSS
771-
// See https://github.com/metafacture/metafacture-fix/issues/119
771+
// See issue metafacture-fix#119
772772
public void shouldPerformComplexOperationWithPathWildcard() {
773773
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
774774
"set_array('coll[]')",

‎metafix/src/test/java/org/metafacture/metafix/MetafixIfTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -634,19 +634,19 @@ public void shouldEqualAny() {
634634
}
635635

636636
@Test
637-
// See https://github.com/metafacture/metafacture-fix/issues/115
637+
// See issue metafacture-fix#115
638638
public void shouldEqualAnyCharacterClass() {
639639
shouldEqualAny("n[ao]me");
640640
}
641641

642642
@Test
643-
// See https://github.com/metafacture/metafacture-fix/issues/115
643+
// See issue metafacture-fix#115
644644
public void shouldEqualAnyAlternation() {
645645
shouldEqualAny("name|nome");
646646
}
647647

648648
@Test
649-
// See https://github.com/metafacture/metafacture-fix/issues/115
649+
// See issue metafacture-fix#115
650650
public void shouldEqualAnyWildcard() {
651651
shouldEqualAny("n?me");
652652
}
@@ -685,7 +685,7 @@ public void shouldEqualAnyNested() {
685685
}
686686

687687
@Test
688-
// See https://github.com/metafacture/metafacture-fix/issues/115
688+
// See issue metafacture-fix#115
689689
public void shouldEqualAnyNestedCharacterClass() {
690690
shouldEqualAnyNested("data.n[ao]me");
691691
}
@@ -696,7 +696,7 @@ public void shouldEqualAnyNestedAlternation() {
696696
}
697697

698698
@Test
699-
// See https://github.com/metafacture/metafacture-fix/issues/115
699+
// See issue metafacture-fix#115
700700
public void shouldEqualAnyNestedWildcard() {
701701
shouldEqualAnyNested("data.n?me");
702702
}
@@ -737,7 +737,7 @@ public void shouldEqualAnyListBind() {
737737
}
738738

739739
@Test
740-
// See https://github.com/metafacture/metafacture-fix/issues/115
740+
// See issue metafacture-fix#115
741741
public void shouldEqualAnyListBindCharacterClass() {
742742
shouldEqualAnyListBind("$i.n[ao]me");
743743
}
@@ -748,7 +748,7 @@ public void shouldEqualAnyListBindAlternation() {
748748
}
749749

750750
@Test
751-
// See https://github.com/metafacture/metafacture-fix/issues/115
751+
// See issue metafacture-fix#115
752752
public void shouldEqualAnyListBindWildcard() {
753753
shouldEqualAnyListBind("$i.n?me");
754754
}
@@ -802,7 +802,7 @@ public void shouldContainImmediateField() {
802802
}
803803

804804
@Test
805-
// See https://github.com/metafacture/metafacture-fix/issues/117
805+
// See issue metafacture-fix#117
806806
public void shouldContainNestedField() {
807807
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
808808
"if exists('data.name')",
@@ -861,7 +861,7 @@ public void shouldContainNestedField() {
861861
}
862862

863863
@Test
864-
// See https://github.com/metafacture/metafacture-fix/issues/117
864+
// See issue metafacture-fix#117
865865
public void shouldContainNestedArrayField() {
866866
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
867867
"if exists('data[].*.name')",

‎metafix/src/test/java/org/metafacture/metafix/MetafixLookupTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ public void shouldLookupMovedExternalArrayWithAsteriskExplicitAppend() {
387387
}
388388

389389
@Test
390-
// See https://github.com/metafacture/metafacture-fix/issues/121
390+
// See issue #601
391391
public void shouldLookupArraySubFieldWithAsterisk() {
392392
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
393393
"lookup('animals[].*.Aanimal', '" + TSV_MAP + "', 'sep_char': '\t')"
@@ -594,7 +594,7 @@ public void shouldDeleteLookupInExternalFileMapWithWrongOptions() {
594594
}
595595

596596
@Test
597-
// See https://github.com/metafacture/metafacture-fix/issues/149
597+
// See issue metafacture-fix#149
598598
public void shouldKeepOriginalValueIfNotFoundAndNoDefault() {
599599
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
600600
"lookup('title.*', Aloha: 'Alohaeha', 'Moin': 'Moin zäme')"
@@ -685,7 +685,7 @@ public void shouldPreferDefaultOptionValueOverDefaultMapValue() {
685685
}
686686

687687
@Test
688-
// See https://github.com/metafacture/metafacture-fix/issues/149
688+
// See issue metafacture-fix#149
689689
public void shouldDeleteNonFoundLookupOnDemand() {
690690
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
691691
"lookup('title.*', Aloha: Alohaeha, 'Moin': 'Moin zäme', delete: 'true')"
@@ -707,7 +707,7 @@ public void shouldDeleteNonFoundLookupOnDemand() {
707707
}
708708

709709
@Test
710-
// See https://github.com/metafacture/metafacture-fix/issues/149
710+
// See issue metafacture-fix#149
711711
public void shouldNotDeleteNonFoundLookupExplicitly() {
712712
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
713713
"lookup('title.*', Aloha: Alohaeha, 'Moin': 'Moin zäme', delete: 'false')"
@@ -773,7 +773,7 @@ public void shouldLookupAfterDeletingUnsuccessfulLookup() {
773773
}
774774

775775
@Test
776-
// See https://github.com/metafacture/metafacture-fix/issues/149
776+
// See issue metafacture-fix#149
777777
public void shouldDeleteNonFoundLookupOnDemandNonRepeatedField() {
778778
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
779779
"lookup('title', Aloha: Alohaeha, 'Moin': 'Moin zäme', delete: 'true')"

‎metafix/src/test/java/org/metafacture/metafix/MetafixMethodTest.java

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ public void wildcardNestedPartialMulti() {
721721
}
722722

723723
@Test
724-
@MetafixToDo("See https://github.com/metafacture/metafacture-fix/issues/121")
724+
@MetafixToDo("See issue #601")
725725
public void wildcardFullFieldNonIndex() {
726726
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
727727
"trim('*')"),
@@ -751,7 +751,7 @@ public void wildcardFullFieldNonIndex() {
751751
}
752752

753753
@Test
754-
@MetafixToDo("See https://github.com/metafacture/metafacture-fix/issues/121")
754+
@MetafixToDo("See issue #601")
755755
public void wildcardNestedFullFieldNonIndex() {
756756
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
757757
"trim('work.*')"),
@@ -902,7 +902,7 @@ public void shouldAppendValueInArray() {
902902
}
903903

904904
@Test
905-
// See https://github.com/metafacture/metafacture-fix/issues/100
905+
// See issue metafacture-fix#100
906906
public void shouldAppendValueInEntireArray() {
907907
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
908908
"append('animals[].*', ' is cool')"
@@ -950,7 +950,7 @@ public void shouldNotAppendValueToArray() {
950950
}
951951

952952
@Test
953-
// See https://github.com/metafacture/metafacture-fix/issues/100
953+
// See issue metafacture-fix#100
954954
public void shouldNotAppendValueToHash() {
955955
MetafixTestHelpers.assertExecutionException(IllegalStateException.class, "Expected String, got Hash", () ->
956956
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
@@ -972,7 +972,7 @@ public void shouldNotAppendValueToHash() {
972972
}
973973

974974
@Test
975-
// See https://github.com/metafacture/metafacture-fix/issues/123
975+
// See issue metafacture-fix#123
976976
public void shouldIncludeLocationAndTextInExecutionException() {
977977
final String text = "append('animals', ' is cool')";
978978
final String message = "Error while executing Fix expression (at FILE, line 2): " + text;
@@ -1270,7 +1270,7 @@ public void shouldConvertInvalidObjectFromJsonWithErrorString() {
12701270
}
12711271

12721272
@Test
1273-
// See https://github.com/metafacture/metafacture-fix/issues/100
1273+
// See issue metafacture-fix#100
12741274
public void shouldFilterArrayObjectValues() {
12751275
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
12761276
"filter('animals[]', '[Cc]at')"
@@ -1611,7 +1611,7 @@ public void shouldJoinSingleField() {
16111611
}
16121612

16131613
@Test
1614-
// See https://github.com/metafacture/metafacture-fix/issues/100
1614+
// See issue metafacture-fix#100
16151615
public void shouldJoinArrayObjectField() {
16161616
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
16171617
"join_field('animals[]', ',')"
@@ -1704,7 +1704,7 @@ public void shouldPrependValueInArray() {
17041704
}
17051705

17061706
@Test
1707-
// See https://github.com/metafacture/metafacture-fix/issues/100
1707+
// See issue metafacture-fix#100
17081708
public void shouldPrependValueInEntireArray() {
17091709
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
17101710
"prepend('animals[].*', 'cool ')"
@@ -1731,7 +1731,7 @@ public void shouldPrependValueInEntireArray() {
17311731
}
17321732

17331733
@Test
1734-
// See https://github.com/metafacture/metafacture-fix/issues/121
1734+
// See issue #601
17351735
public void shouldPrependValueInNestedArray() {
17361736
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
17371737
"prepend('nestedTest[].*.test[].*', 'Number ')"
@@ -1777,7 +1777,7 @@ public void shouldPrependValueInNestedArray() {
17771777
}
17781778

17791779
@Test
1780-
// See https://github.com/metafacture/metafacture-fix/issues/121
1780+
// See issue #601
17811781
public void shouldPrependValueInArraySubField() {
17821782
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
17831783
"prepend('coll[].*.a', 'HELLO ')"
@@ -1825,7 +1825,7 @@ public void shouldPrependValueInArraySubField() {
18251825
}
18261826

18271827
@Test
1828-
// See https://github.com/metafacture/metafacture-fix/issues/100
1828+
// See issue metafacture-fix#100
18291829
public void shouldNotPrependValueToArray() {
18301830
MetafixTestHelpers.assertExecutionException(IllegalStateException.class, "Expected String, got Array", () ->
18311831
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
@@ -1963,7 +1963,7 @@ public void shouldReplaceAllRegexesWithGroupName() {
19631963
}
19641964

19651965
@Test
1966-
// See https://github.com/metafacture/metafacture-fix/issues/100
1966+
// See issue metafacture-fix#100
19671967
public void shouldReplaceAllRegexesInArray() {
19681968
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
19691969
"replace_all('animals[].*', a, QR)"
@@ -1990,7 +1990,7 @@ public void shouldReplaceAllRegexesInArray() {
19901990
}
19911991

19921992
@Test
1993-
// See https://github.com/metafacture/metafacture-fix/issues/121
1993+
// See issue #601
19941994
public void shouldReplaceAllRegexesInArraySubField() {
19951995
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
19961996
"replace_all('coll[].*.a', 'o', '__')"
@@ -2038,7 +2038,7 @@ public void shouldReplaceAllRegexesInArraySubField() {
20382038
}
20392039

20402040
@Test
2041-
// See https://github.com/metafacture/metafacture-fix/issues/255
2041+
// See issue metafacture-fix#255
20422042
public void shouldFailToReplaceAllInRepeatedSubfieldOfObjectWithAsterisk() {
20432043
MetafixTestHelpers.assertProcessException(IllegalArgumentException.class, "Can't find: 2 in: null", () ->
20442044
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
@@ -2707,7 +2707,7 @@ public void shouldMoveFieldToPathWithTwoReservedFields() {
27072707
}
27082708

27092709
@Test
2710-
// See https://github.com/metafacture/metafacture-fix/issues/121
2710+
// See issue #601
27112711
public void shouldReplaceAllRegexesInNestedArray() {
27122712
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
27132713
"replace_all('nestedTest[].*.test[].*', 'o', '__')"
@@ -3172,7 +3172,7 @@ public void shouldReverseArray() {
31723172
}
31733173

31743174
@Test
3175-
@MetafixToDo("See https://github.com/metafacture/metafacture-fix/issues/121")
3175+
@MetafixToDo("See issue #601")
31763176
public void shouldReverseArrayOfStringsWithAsterisk() {
31773177
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
31783178
"reverse('test[].*')"
@@ -3199,7 +3199,7 @@ public void shouldReverseArrayOfStringsWithAsterisk() {
31993199
}
32003200

32013201
@Test
3202-
@MetafixToDo("java.lang.ArrayIndexOutOfBoundsException: 0; see https://github.com/metafacture/metafacture-fix/issues/121")
3202+
@MetafixToDo("java.lang.ArrayIndexOutOfBoundsException: 0; see issue #601")
32033203
public void shouldReverseArrayOfHashesWithAsterisk() {
32043204
MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
32053205
"reverse('ANIMALS[].*')"

0 commit comments

Comments
 (0)