Skip to content

Conversation

@jasonbcox
Copy link
Contributor

This makes the code easier to read and more robust against regressions by avoiding duplicate changes to both code paths. The early return in the Curve25519 path also makes it more clear that nothing else is happening in that code path.

The few duplicate lines to handle encrypted.size and which_payload_variant before returning is a small price to pay for this improvement.

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

@thebentern thebentern added the enhancement New feature or request label Nov 20, 2025
@thebentern thebentern requested a review from Copilot November 20, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants