Dedup happy path for encrypting shared channel packets #8671
+7
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code easier to read and more robust against regressions by avoiding duplicate changes to both code paths. The early return in the Curve25519 path also makes it more clear that nothing else is happening in that code path.
The few duplicate lines to handle encrypted.size and which_payload_variant before returning is a small price to pay for this improvement.
🤝 Attestations