Refactor RadioLibInterface to support multiple instances #8587
Conversation
…elated references
| /** Our ISR code currently needs this to find our active instance | ||
| */ | ||
| RadioLibInterface *RadioLibInterface::instance; | ||
| std::vector<RadioLibInterface*> RadioLibInterface::instances; |
There was a problem hiding this comment.
Because this is a static variable you have to explicitly remove instances that have been pushed into this vector when the instance (i.e. an instance of a derived class of RadioLibInterface) is deleted as in main.cpp where several radio chip types are probed.
There was a problem hiding this comment.
I currently have two radio interfaces running. The variable must be static, as it needs to be accessed from an interrupt.
The problem is that there is not enough IRAM memory on the ESP32, I will solve it.
There was a problem hiding this comment.
Still, you need to remove instances from the vector in the dtor, otherwise the vector will contain pointers to deleted objects.
There was a problem hiding this comment.
Hi, I’ve opened a new PR, could you check it?
#8607
3 participants
These changes make it possible to determine which LoRa module triggered the interrupt by reading the GPIO state.
This allows for creating multiple instances of RadioLibInterface.
#3831
🤝 Attestations