Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog schema: Proposal to shift classes from enum to oneof type string #109

Closed
leecalcote opened this issue Jul 22, 2024 · 2 comments
Closed
Labels
issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature kind/question Further information is requested

Comments

@leecalcote
Copy link
Member

Current Behavior

Regarding this discussion, meshery/meshkit#542 (comment), the current approach to having Catalog content class descriptions in a separate, single property makes extraction of the enum value and its corresponding description a bit more challenging than is perhaps necessary.

Proposal:

{
    "type": "string",
    "oneOf": [
        { "const": "open", "description": "The issue is currently open." },
        { "const": "closed", "description": "The issue has been resolved." },
        { "const": "pending" } // Waiting for more information
    ]
}

Contributor Guides and Handbook

@leecalcote leecalcote added kind/enhancement Improvement in current feature kind/question Further information is requested labels Jul 22, 2024
Copy link

stale bot commented Sep 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 2, 2024
Copy link

stale bot commented Sep 14, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature kind/question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant