Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Usage of window.pageYOffset #205

Closed
akshansh-modi opened this issue Jul 4, 2024 · 3 comments · Fixed by #207
Closed

Deprecated Usage of window.pageYOffset #205

akshansh-modi opened this issue Jul 4, 2024 · 3 comments · Fixed by #207
Assignees
Labels
kind/bug Something isn't working

Comments

@akshansh-modi
Copy link
Contributor

Current Behavior

The codebase currently utilizes window.pageYOffset, which is deprecated in favor of window.scrollY for accessing the vertical scroll position of the document. It's recommended to update the codebase to use window.scrollY instead to ensure compatibility and future-proofing.

Expected Behavior

Update the codebase to use window.scrollY instead of window.pageYOffset.

Code Location

play\site\src\components\Navigation\index.js

Screenshots/Logs

image


Contributor Guides and Resources

@akshansh-modi akshansh-modi added the kind/bug Something isn't working label Jul 4, 2024
@akshansh-modi
Copy link
Contributor Author

Hi, I would like to work on this issue. Could you please assign it to me?

@Ashparshp
Copy link

Thanks for addressing this! But Ensure compatibility with our React and dependencies versions..

@akshansh-modi
Copy link
Contributor Author

@Ashparshp
Please review the changes and provide feedback. Let me know if any further adjustments are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants