Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename design.meshmodel.io to id.design.meshery.io. #472

Closed
MUzairS15 opened this issue Mar 7, 2024 · 11 comments · May be fixed by #545
Closed

Rename design.meshmodel.io to id.design.meshery.io. #472

MUzairS15 opened this issue Mar 7, 2024 · 11 comments · May be fixed by #545
Labels
issue/willfix This issue will be worked on

Comments

@MUzairS15
Copy link

MUzairS15 commented Mar 7, 2024

          @MUzairS15 this is to be `design.meshery.io`, right?

Originally posted by @leecalcote in #468 (comment)

The renaming of the annotation will impact UI clients.
The changes must be coordinated with the affected UI clients.

@AllenOps08
Copy link

I want to work on this. Is anyone currently working on this @leecalcote? Also can you explain a bit about this.

@MUzairS15 MUzairS15 changed the title Rename design.meshmodel.io to design.meshery.io. Rename design.meshmodel.io to id.design.meshery.io. Mar 12, 2024
@leecalcote
Copy link
Member

Thank you @AllenOps08. 👏

@leecalcote
Copy link
Member

leecalcote commented Mar 15, 2024

@AllenOps08 here is a bit of background about the purpose of this annotation - Greenfield: Tracking newly created resources.

Ideally, a PR that you open on this repo with a change is conjoined by a PR opened on meshery/meshery for a Docs update to that page, too.

Copy link

stale bot commented May 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label May 2, 2024
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label May 2, 2024
@leecalcote leecalcote added issue/stale Issue has not had any activity for an extended period of time issue/willfix This issue will be worked on labels May 2, 2024
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label May 2, 2024
@ayushrakesh
Copy link

@leecalcote Please assign this issue to me, I want to work.

@akshansh-modi
Copy link

@leecalcote i would like to work on this .

@akshansh-modi
Copy link

akshansh-modi commented Jul 30, 2024

@leecalcote , I’ve implemented the changes in meshkit, and all the test cases are passing. Is there anything else I need to do before moving forward with the pull request?

@leecalcote
Copy link
Member

@akshansh-modi that's good to hear. I suspect that we won't know until you open a PR.

@leecalcote
Copy link
Member

leecalcote commented Jul 30, 2024

One item to verify is that when this change is made, you can still deploy a design, and have it's "Open in Vizualizer" link work. You'll likely need the help of another maintainer to confirm this. You can call it out in your open PR.

@akshansh-modi
Copy link

ok @leecalcote

@MUzairS15
Copy link
Author

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants