-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename design.meshmodel.io
to id.design.meshery.io
.
#472
Comments
I want to work on this. Is anyone currently working on this @leecalcote? Also can you explain a bit about this. |
design.meshmodel.io
to design.meshery.io
.design.meshmodel.io
to id.design.meshery.io
.
Thank you @AllenOps08. 👏 |
@AllenOps08 here is a bit of background about the purpose of this annotation - Greenfield: Tracking newly created resources. Ideally, a PR that you open on this repo with a change is conjoined by a PR opened on |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@leecalcote Please assign this issue to me, I want to work. |
@leecalcote i would like to work on this . |
@leecalcote , I’ve implemented the changes in meshkit, and all the test cases are passing. Is there anything else I need to do before moving forward with the pull request? |
@akshansh-modi that's good to hear. I suspect that we won't know until you open a PR. |
One item to verify is that when this change is made, you can still deploy a design, and have it's "Open in Vizualizer" link work. You'll likely need the help of another maintainer to confirm this. You can call it out in your open PR. |
ok @leecalcote |
Completed |
Originally posted by @leecalcote in #468 (comment)
The renaming of the annotation will impact UI clients.
The changes must be coordinated with the affected UI clients.
The text was updated successfully, but these errors were encountered: