Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog Modal responsive issue #2017

Open
vishalvivekm opened this issue Jan 11, 2025 · 8 comments
Open

Catalog Modal responsive issue #2017

vishalvivekm opened this issue Jan 11, 2025 · 8 comments
Assignees
Labels
framework/jekyll Issues or pull requests that use Jekyll good first issue Good for newcomers language/css language/html Issues or pull requests that use HTML language/javascript Javascript rela

Comments

@vishalvivekm
Copy link
Contributor

          @Tharanishwaran 

There should be no effect on hover; it just needs to stay as a chip.

Also, I understand that the following may not be within the scope of the corresponding issue, but could you please take a look at fixing these two points:

  1. Modal's height:
    image

  2. the unwanted border:

image

Originally posted by @Touriist in #2015 (review)

@vishalvivekm vishalvivekm added good first issue Good for newcomers language/javascript Javascript rela framework/jekyll Issues or pull requests that use Jekyll language/html Issues or pull requests that use HTML language/css labels Jan 11, 2025
@devanshsonii
Copy link

Could I work on this?

@vishalvivekm
Copy link
Contributor Author

Could I work on this?

Thanks for volunteering, would you please confirm if you have set up the project and can run it locally?

@devanshsonii
Copy link

Yes I have set up the project

@devanshsonii
Copy link

I have fixed the border issue. Could you elaborate more on the first one?

@vishalvivekm
Copy link
Contributor Author

I have fixed the border issue. Could you elaborate more on the first one?

@devanshsonii Great.
Yes, please visit https://meshery.io/catalog in desktop and open any design card. The modal has way too much height so much so that it goes beyond the view as can be seen from the screenshot posted by @Touriist.
Let me know if you need any further clarification.

@devanshsonii
Copy link

image It seems to be working alright in my machine, i have tried three seperate browsers (safari, chrome and firefox) trying to replicate the issue. Could you perhaps tell me about the environment used?

@vishalvivekm
Copy link
Contributor Author

image It seems to be working alright in my machine, i have tried three seperate browsers (safari, chrome and firefox) trying to replicate the issue. Could you perhaps tell me about the environment used?

Thanks for confirming. We'll take a look at this in today's websites meeting at 7 AM CT | 6:30 PM IST
Meeting link: https://meet.layer5.io/websites

Copy link

stale bot commented Feb 12, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/jekyll Issues or pull requests that use Jekyll good first issue Good for newcomers language/css language/html Issues or pull requests that use HTML language/javascript Javascript rela
Projects
None yet
Development

No branches or pull requests

2 participants