Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Navbar is not closing on click getting started in mobile view #1888

Open
amitamrutiya opened this issue Aug 25, 2024 · 7 comments · May be fixed by #1889
Open

[UI] Navbar is not closing on click getting started in mobile view #1888

amitamrutiya opened this issue Aug 25, 2024 · 7 comments · May be fixed by #1889
Assignees
Labels
area/website component/ui User Interface good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working

Comments

@amitamrutiya
Copy link
Contributor

Description

In mobile view, when we click on "Getting Started," the navbar menu does not close.

Expected Behavior

In mobile view, the navbar should close when "Getting Started" is clicked.

Screenshots

image

Environment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@amitamrutiya amitamrutiya added kind/bug Something isn't working good first issue Good for newcomers component/ui User Interface area/website labels Aug 25, 2024
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@leecalcote leecalcote added the help wanted Extra attention is needed label Aug 25, 2024
@hymmns
Copy link

hymmns commented Aug 25, 2024

Hi @amitamrutiya, could this be assigned to me. Would like to work on it

@agamjotpanesar
Copy link

Hi @amitamrutiya
I want to work on this issue. Can you please assign it to me.

@amitamrutiya
Copy link
Contributor Author

@agamjotpanesar Thanks for showing interest in solving this issue. We are assigning tasks in chronological order, so you can find a different issue to work on.

@hymmns, you're good to go—let's make this happen!

@porobertdev
Copy link

I managed to fix it with vanilla JS while testing in DevTools.

Tip The `display` of the navbar's ul needs to be set to _none_ once the _Getting Started_ li is clicked_.

Hope it helps :)

Please let me know if my behavior is ok. It's the first time I do this, and I thought it's ok as a tip since someone else has been already assigned. Thank you!

@hymmns
Copy link

hymmns commented Aug 27, 2024

@porobertdev Thanks for the input.

@hymmns
Copy link

hymmns commented Aug 27, 2024

@amitamrutiya Please let me know if this fixes the issue or if there's any other comment kindly drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website component/ui User Interface good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants