Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Next button invisible when click on #1863

Open
amitamrutiya opened this issue Aug 14, 2024 · 7 comments · May be fixed by #1893
Open

[UI] Next button invisible when click on #1863

amitamrutiya opened this issue Aug 14, 2024 · 7 comments · May be fixed by #1893
Labels
kind/bug Something isn't working

Comments

@amitamrutiya
Copy link
Contributor

amitamrutiya commented Aug 14, 2024

Description

Link: Extension Page
On this page, when the "Next" button is clicked, it becomes invisible.

Expected Behavior

If we choose not to use pagination, remove the "Next" and "Previous" buttons; otherwise, apply pagination.

Screenshots

Screencast.from.2024-08-14.16-39-36.webm

Environment:

  • OS: Linux
  • Browser: Firefox
  • Version: latest
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@amitamrutiya amitamrutiya added the kind/bug Something isn't working label Aug 14, 2024
@Aviral0702
Copy link
Contributor

@amitamrutiya I can reproduce the issue. You can ask for assignment and then go ahead.

@abbi4code
Copy link

Can i work on this issue?

@Ashparshp
Copy link

@amitamrutiya, @Aviral0702, we've implemented the pagination, right? The issue is that we don't have more cards to show when clicking Next. So, can we add a condition instead of removing the button?

@amitamrutiya
Copy link
Contributor Author

Yeah that makes sense.

@Aviral0702
Copy link
Contributor

@Ashparshp Makes sense.

@Ashparshp
Copy link

Ashparshp commented Sep 8, 2024

@abbi4code, read the discussion and go accordingly. Please don't remove.

@abbi4code
Copy link

@Ashparshp Yeah, I got it. Instead of completely removing the 'Next' button, we can add a condition to check if there are more cards available to display. If there are more cards, the button should remain active, but if not, we can either disable the button or hide it. This way, we keep the pagination logic intact without breaking the user flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants