Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Two-Column Layout for Mobile #1827

Open
Ashparshp opened this issue Jul 18, 2024 · 11 comments
Open

Implement Two-Column Layout for Mobile #1827

Ashparshp opened this issue Jul 18, 2024 · 11 comments
Assignees
Labels
first timers only Welcome first time contributors! good first issue Good for newcomers kind/bug Something isn't working language/css

Comments

@Ashparshp
Copy link

Description

Update the mobile view to use a two-column layout for better space utilization in footer section.

Expected Behavior

Screenshots

Screenshot_2024-07-18-17-57-20-728_com android chrome

Enviroment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@Ashparshp Ashparshp added kind/bug Something isn't working good first issue Good for newcomers first timers only Welcome first time contributors! language/css labels Jul 18, 2024
@AdityaDKale
Copy link

AdityaDKale commented Jul 18, 2024

Hello I want to work on this issue. Can you please assign it to me.

@Ashparshp
Copy link
Author

@AdityaDKale You're new to the community?

@AdityaDKale
Copy link

Yes

@Ashparshp
Copy link
Author

@AdityaDKale Go ahead!!

@AdityaDKale
Copy link

Hey this is actually already creating two column layout above 450px
image
And below that it is shifting to single column layout to avoid overflow which can be caused by overlapping of the container items. I think forcing two column layout may cause overflow and overlapping of text. We can try reducing the margins or reducing the size of container-items but maybe it is not a good idea to force two column layout.

I may be wrong here but I think it requires a further discussion before any code changes. Thanks and apologizes if I come out in a rude way.

@vishalvivekm
Copy link
Member

@AdityaDKale
Let's discuss this one on websites call, please add it in agenda items if you would :) /
Meeting minutes: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit

@Ashparshp
Copy link
Author

@AdityaDKale Let's discuss this in evening call.. adding this to the meeting minutes..

@Aarav238
Copy link

Hey @AdityaDKale , I would really like to work on it.
can you please assign this to me..

@rahulrana701
Copy link
Contributor

@Ashparshp can I take up this issue ?

@Ashparshp
Copy link
Author

Thank you for showing interest @Aarav238! However, I noticed that @rahulrana701, have some pending assignments and PRs. Please prioritize completing those first. Also, as we usually do, let’s proceed with tasks in chronological order. I’m assigning this task to Aarav for now.

@Ashparshp Ashparshp assigned Aarav238 and unassigned AdityaDKale Aug 21, 2024
@Aarav238
Copy link

@Ashparshp Thanks. I will try to raise a PR as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first timers only Welcome first time contributors! good first issue Good for newcomers kind/bug Something isn't working language/css
Projects
None yet
Development

No branches or pull requests

5 participants