Merge pull request #86 from rdeits/rd/github-ci

Try turning on github CI

Author: rdeits

.github/workflows/CI.yaml

@@ -0,0 +1,37 @@
+name: Python package
+
+on: [push]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: [3.6, 3.7, 3.8]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install flake8 pytest pytest-cov
+        git submodule update --init --recursive
+        pip install -e .
+    - name: Lint with flake8
+      run: |
+        # stop the build if there are Python syntax errors or undefined names
+        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+    - name: Test with pytest
+      run: |
+        pytest --cov=./
+    - name: "Upload coverage to Codecov"
+      uses: codecov/codecov-action@v1
+      with:
+        fail_ci_if_error: true

.travis.yml

@@ -2,6 +2,8 @@
 2. Create a new tag:
 
     git tag -a "v1.2.3"
+    git push
+    git push --tags
 
 3. Upload
 

publishing_notes.md

@@ -7,7 +7,7 @@ class SetObject:
     def __init__(self, geometry_or_object, material=None, path=None):
         if isinstance(geometry_or_object, Object):
             if material is not None:
-                raise(ArgumentError("Please supply either an Object OR a Geometry and a Material"))
+                raise(ValueError("Please supply either an Object OR a Geometry and a Material"))
             self.object = geometry_or_object
         elif isinstance(geometry_or_object, OrthographicCamera):
             self.object = geometry_or_object

src/meshcat/commands.py

@@ -21,7 +21,7 @@ async def handle_new_connection(websocket, path):
             msg = await my_queue.get()
             await websocket.send(msg)
     except websockets.ConnectionClosed as e:
-        queues.remove(queue)
+        queues.remove(my_queue)
 
 start_server = websockets.serve(handle_new_connection, '127.0.0.1', 8765)
 asyncio.get_event_loop().run_until_complete(start_server)