Skip to content

Commit 17cb7e9

Browse files
committed
chore: update changelog to include fix for gallery gap offset issue
1 parent de56ba7 commit 17cb7e9

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery-design-properties.scss

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
//== Design Properties
55
//## Helper classes to change the look and feel of the component
66
========================================================================== */
7+
:root {
8+
--gallery-gap: var(--spacing-small, $dg-spacing-small);
9+
}
10+
711
// All borders
812
.widget-gallery-bordered-all {
913
.widget-gallery-item {
@@ -43,7 +47,7 @@
4347
left: 0;
4448
right: 0;
4549
border-bottom: 1px solid var(--grid-border-color, $grid-border-color);
46-
margin-top: calc(var(--spacing-small, $spacing-small) / 2);
50+
margin-top: calc(var(--gallery-gap) / 2 - 1px);
4751
}
4852
}
4953
}
@@ -70,27 +74,31 @@
7074
// Grid spacing none
7175
.widget-gallery.widget-gallery-gridgap-none {
7276
.widget-gallery-items {
77+
--gallery-gap: 0px;
7378
gap: 0;
7479
}
7580
}
7681

7782
// Grid spacing small
7883
.widget-gallery.widget-gallery-gridgap-small {
7984
.widget-gallery-items {
85+
--gallery-gap: var(--spacing-small, $dg-spacing-small);
8086
gap: var(--spacing-small, $spacing-small);
8187
}
8288
}
8389

8490
// Grid spacing medium
8591
.widget-gallery.widget-gallery-gridgap-medium {
8692
.widget-gallery-items {
93+
--gallery-gap: var(--spacing-medium, $dg-spacing-medium);
8794
gap: var(--spacing-medium, $spacing-medium);
8895
}
8996
}
9097

9198
// Grid spacing large
9299
.widget-gallery.widget-gallery-gridgap-large {
93100
.widget-gallery-items {
101+
--gallery-gap: var(--spacing-large, $dg-spacing-large);
94102
gap: var(--spacing-large, $spacing-large);
95103
}
96104
}

packages/pluggableWidgets/gallery-web/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Fixed
10+
11+
- We fixed an issue where setting the gallery gap to 0 caused an offset, which made the bottom border of items to dissapear.
12+
913
## [3.4.0] - 2025-09-12
1014

1115
### Fixed

0 commit comments

Comments
 (0)