Skip to content

Commit f61797d

Browse files
authored
revert safeAreaView update (#228)
2 parents 1f3ec49 + db178b8 commit f61797d

File tree

6 files changed

+14
-47
lines changed

6 files changed

+14
-47
lines changed

Diff for: packages/pluggableWidgets/safe-area-view-native/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
## Fixed
10+
11+
- We reverted latest SafeAreaView change since it was causing another issue which the SafeAreaView wasn't covering whole screen.
12+
913
## [3.0.0] - 2024-12-18
1014

1115
## Fixed

Diff for: packages/pluggableWidgets/safe-area-view-native/package.json

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "safe-area-view-native",
33
"widgetName": "SafeAreaView",
4-
"version": "3.0.0",
4+
"version": "3.0.1",
55
"license": "Apache-2.0",
66
"repository": {
77
"type": "git",
@@ -20,8 +20,7 @@
2020
},
2121
"dependencies": {
2222
"@mendix/piw-native-utils-internal": "*",
23-
"@mendix/piw-utils-internal": "*",
24-
"react-native-safe-area-context": "4.11.0"
23+
"@mendix/piw-utils-internal": "*"
2524
},
2625
"devDependencies": {
2726
"@mendix/pluggable-widgets-tools": "~10.0.1",

Diff for: packages/pluggableWidgets/safe-area-view-native/src/SafeAreaView.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { createElement } from "react";
2-
import { View } from "react-native";
3-
import { SafeAreaView as ReactSaveAreaView } from "react-native-safe-area-context";
2+
import { SafeAreaView as ReactSaveAreaView, View } from "react-native";
43
import { flattenStyles } from "@mendix/piw-native-utils-internal";
54

65
import { SafeAreaViewStyle, defaultSafeAreaViewStyle } from "./ui/Styles";

Diff for: packages/pluggableWidgets/safe-area-view-native/src/__tests__/__snapshots__/SafeAreaView.spec.tsx.snap

+6-30
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,7 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

33
exports[`Safe area view renders with content 1`] = `
4-
<RNCSafeAreaView
5-
edges={
6-
{
7-
"bottom": "additive",
8-
"left": "additive",
9-
"right": "additive",
10-
"top": "additive",
11-
}
12-
}
4+
<View
135
pointerEvents="box-none"
146
style={
157
{
@@ -31,19 +23,11 @@ exports[`Safe area view renders with content 1`] = `
3123
Content
3224
</Text>
3325
</View>
34-
</RNCSafeAreaView>
26+
</View>
3527
`;
3628

3729
exports[`Safe area view renders with custom styling 1`] = `
38-
<RNCSafeAreaView
39-
edges={
40-
{
41-
"bottom": "additive",
42-
"left": "additive",
43-
"right": "additive",
44-
"top": "additive",
45-
}
46-
}
30+
<View
4731
pointerEvents="box-none"
4832
style={
4933
{
@@ -66,19 +50,11 @@ exports[`Safe area view renders with custom styling 1`] = `
6650
Content
6751
</Text>
6852
</View>
69-
</RNCSafeAreaView>
53+
</View>
7054
`;
7155

7256
exports[`Safe area view renders without content 1`] = `
73-
<RNCSafeAreaView
74-
edges={
75-
{
76-
"bottom": "additive",
77-
"left": "additive",
78-
"right": "additive",
79-
"top": "additive",
80-
}
81-
}
57+
<View
8258
pointerEvents="box-none"
8359
style={
8460
{
@@ -96,5 +72,5 @@ exports[`Safe area view renders without content 1`] = `
9672
}
9773
}
9874
/>
99-
</RNCSafeAreaView>
75+
</View>
10076
`;

Diff for: packages/pluggableWidgets/safe-area-view-native/src/package.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="SafeAreaView" version="3.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="SafeAreaView" version="3.0.1" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="SafeAreaView.xml" />
66
</widgetFiles>

Diff for: yarn.lock

-11
Original file line numberDiff line numberDiff line change
@@ -16018,16 +16018,6 @@ __metadata:
1601816018
languageName: node
1601916019
linkType: hard
1602016020

16021-
"react-native-safe-area-context@npm:4.11.0":
16022-
version: 4.11.0
16023-
resolution: "react-native-safe-area-context@npm:4.11.0"
16024-
peerDependencies:
16025-
react: "*"
16026-
react-native: "*"
16027-
checksum: 10/f2e616ad3087ebf1ad34f90f4eadc2d6865d3d56bba83bcfb9d04020b4344d892e347b7f55dcd996c4d2edf21b589a5ce710a52e62a7bd86597ed34d130599b2
16028-
languageName: node
16029-
linkType: hard
16030-
1603116021
"react-native-schedule-exact-alarm-permission@npm:^0.1.3":
1603216022
version: 0.1.4
1603316023
resolution: "react-native-schedule-exact-alarm-permission@npm:0.1.4"
@@ -16991,7 +16981,6 @@ __metadata:
1699116981
"@mendix/piw-utils-internal": "npm:*"
1699216982
"@mendix/pluggable-widgets-tools": "npm:~10.0.1"
1699316983
eslint: "npm:^7.32.0"
16994-
react-native-safe-area-context: "npm:4.11.0"
1699516984
languageName: unknown
1699616985
linkType: soft
1699716986

0 commit comments

Comments
 (0)