Merge pull request #310 from membraneframework/release/v0.7.0

Release membrane_core v0.7.0

Author: mickel8

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2.0
 jobs:
   test:
     docker:
-      - image: membrane/membrane:latest
+      - image: membraneframeworklabs/docker_membrane
         environment:
           MIX_ENV: test
 
@@ -17,7 +17,7 @@ jobs:
 
   lint:
     docker:
-      - image: membrane/bionic-membrane:latest
+      - image: membraneframeworklabs/docker_membrane
         environment:
           MIX_ENV: dev
 
@@ -29,6 +29,7 @@ jobs:
       - run: mix format --check-formatted
       - run: mix compile
       - run: mix credo
+      - run: mix dialyzer 
       - run: mix docs && mix docs 2>&1 | (! grep -q "warning:")
 
 workflows:

lib/membrane/bin/action.ex

@@ -65,7 +65,7 @@ defmodule Membrane.Bin.Action do
   was previously set to `:no_interval`.
 
   If the `interval` is `:no_interval`, the timer won't issue any ticks until
-  another `t:set_interval_t/0` action. Otherwise, the timer will issue ticks every
+  another `t:timer_interval_t/0` action. Otherwise, the timer will issue ticks every
   new `interval`. The next tick after interval change is scheduled at
   `new_interval + previous_time`, where previous_time is the time of the latest
   tick or the time of returning `t:start_timer_t/0` action if no tick has been

lib/membrane/core/bin/state.ex

@@ -14,6 +14,7 @@ defmodule Membrane.Core.Bin.State do
   alias Membrane.Core.Parent.Link
   alias Membrane.Core.Parent.ChildrenModel
   alias Membrane.{Child, Clock, Sync}
+  alias Membrane.Core.Parent.CrashGroup
 
   @type t :: %__MODULE__{
           internal_state: Membrane.Bin.state_t() | nil,

lib/membrane/core/callback_handler.ex

@@ -24,6 +24,7 @@ defmodule Membrane.Core.CallbackHandler do
           {:ok, internal_state}
           | {{:ok, [action]}, internal_state}
           | {{:error, any}, internal_state}
+          | {:error, any}
 
   @type callback_return_t :: callback_return_t(any, any)
 

lib/membrane/core/element/caps_controller.ex

@@ -6,7 +6,7 @@ defmodule Membrane.Core.Element.CapsController do
   use Bunch
 
   alias Membrane.{Caps, Pad}
-  alias Membrane.Core.{CallbackHandler, InputBuffer}
+  alias Membrane.Core.{CallbackHandler, InputBuffer, Telemetry}
   alias Membrane.Core.Child.PadModel
   alias Membrane.Core.Element.{ActionHandler, State}
   alias Membrane.Element.CallbackContext
@@ -19,6 +19,8 @@ defmodule Membrane.Core.Element.CapsController do
   """
   @spec handle_caps(Pad.ref_t(), Caps.t(), State.t()) :: State.stateful_try_t()
   def handle_caps(pad_ref, caps, state) do
+    Telemetry.report_metric("caps", 1, inspect(pad_ref))
+
     PadModel.assert_data!(state, pad_ref, %{direction: :input})
     data = PadModel.get_data!(state, pad_ref)
 

lib/membrane/core/element/demand_handler.ex

@@ -166,9 +166,7 @@ defmodule Membrane.Core.Element.DemandHandler do
     else
       {{:error, reason}, state} ->
         Membrane.Logger.error("""
-        Error while supplying demand on pad #{inspect(pad_ref)} of size #{
-          inspect(pad_data.demand)
-        }
+        Error while supplying demand on pad #{inspect(pad_ref)} of size #{inspect(pad_data.demand)}
         """)
 
         {{:error, {:supply_demand, reason}}, %State{state | supplying_demand?: false}}

lib/membrane/core/element/event_controller.ex

@@ -6,7 +6,7 @@ defmodule Membrane.Core.Element.EventController do
   use Bunch
 
   alias Membrane.{Event, Pad, Sync}
-  alias Membrane.Core.{CallbackHandler, Events, InputBuffer, Message}
+  alias Membrane.Core.{CallbackHandler, Events, InputBuffer, Message, Telemetry}
   alias Membrane.Core.Child.PadModel
   alias Membrane.Core.Element.{ActionHandler, State}
   alias Membrane.Element.CallbackContext
@@ -27,6 +27,8 @@ defmodule Membrane.Core.Element.EventController do
   """
   @spec handle_event(Pad.ref_t(), Event.t(), State.t()) :: State.stateful_try_t()
   def handle_event(pad_ref, event, state) do
+    Telemetry.report_metric("event", 1, inspect(pad_ref))
+
     pad_data = PadModel.get_data!(state, pad_ref)
 
     if not Event.async?(event) && pad_data.mode == :pull && pad_data.direction == :input &&
@@ -158,9 +160,7 @@ defmodule Membrane.Core.Element.EventController do
         {{:ok, :ignore}, state}
 
       playback: %{state: playback_state} ->
-        raise "Received end of stream event in an incorrect state. State: #{
-                inspect(playback_state, pretty: true)
-              }, on pad: #{inspect(pad_ref)}"
+        raise "Received end of stream event in an incorrect state. State: #{inspect(playback_state, pretty: true)}, on pad: #{inspect(pad_ref)}"
     end
   end
 

lib/membrane/core/element/lifecycle_controller.ex

@@ -70,9 +70,7 @@ defmodule Membrane.Core.Element.LifecycleController do
       Membrane.Logger.debug("Terminating element, reason: #{inspect(reason)}")
     else
       Membrane.Logger.warn("""
-      Terminating element possibly not prepared for termination as it was in state #{
-        inspect(playback_state)
-      }.
+      Terminating element possibly not prepared for termination as it was in state #{inspect(playback_state)}.
       Reason: #{inspect(reason)}",
       State: #{inspect(state, pretty: true)}
       """)

lib/membrane/core/element/playback_buffer.ex

@@ -115,15 +115,11 @@ defmodule Membrane.Core.Element.PlaybackBuffer do
     pad_ref = Message.for_pad(msg)
 
     with :ok <- PadModel.assert_data(state, pad_ref, %{direction: :output}) do
-      Membrane.Logger.debug_verbose(
-        "Received #{
-          if size == 0 do
-            "dumb demand"
-          else
-            "demand of size #{inspect(size)}"
-          end
-        } on pad #{inspect(pad_ref)}"
-      )
+      Membrane.Logger.debug_verbose("Received #{if size == 0 do
+        "dumb demand"
+      else
+        "demand of size #{inspect(size)}"
+      end} on pad #{inspect(pad_ref)}")
 
       DemandController.handle_demand(pad_ref, size, state)
     end

lib/membrane/core/input_buffer.ex

@@ -10,10 +10,8 @@ defmodule Membrane.Core.InputBuffer do
   use Bunch
 
   alias Membrane.Buffer
-  alias Membrane.Core.Message
+  alias Membrane.Core.{Message, Telemetry}
   alias Membrane.Pad
-  alias Membrane.Telemetry
-  alias Membrane.ComponentPath
 
   require Membrane.Core.Message
   require Membrane.Logger
@@ -326,17 +324,7 @@ defmodule Membrane.Core.InputBuffer do
   end
 
   defp report_buffer_size(method, size, %__MODULE__{log_tag: log_tag}) do
-    :telemetry.execute(
-      Telemetry.input_buffer_size_event_name(),
-      %{
-        element_path:
-          ComponentPath.get_formatted() <>
-            "/" <> (log_tag || ""),
-        method: method,
-        value: size
-      },
-      %{}
-    )
+    Telemetry.report_metric(method, size, log_tag)
   end
 
   @spec empty?(t()) :: boolean()