Merge #586

586: Fix add_document behaviour with empty string r=alallema a=adripo



# Pull Request

## Related issue
Fixes #585

## What does this PR do?
- Receive a formal message for this case from Meilisearch API.
- Test correct functionality

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: adripo <[email protected]>
Co-authored-by: Amélie <[email protected]>

Author: 3 people

meilisearch/_httprequests.py

@@ -45,7 +45,7 @@ def send_request(
                     request_path,
                     timeout=self.config.timeout,
                     headers=self.headers,
-                    data=json.dumps(body) if body else "null",
+                    data=json.dumps(body) if body else "" if body == "" else "null",
                 )
             return self.__validate(request)
 

tests/index/test_index_document_meilisearch.py

@@ -26,6 +26,16 @@ def test_add_documents(empty_index, small_movies):
     assert update.status == "succeeded"
 
 
+def test_add_documents_empty(empty_index):
+    """Tests adding empty string as documents to a clean index."""
+    index = empty_index()
+    with pytest.raises(Exception) as e_info:
+        index.add_documents("")
+    assert e_info.value.code == "missing_payload"
+    assert e_info.value.type == "invalid_request"
+    assert e_info.value.link == "https://docs.meilisearch.com/errors#missing_payload"
+
+
 @pytest.mark.parametrize("batch_size", [2, 3, 1000])
 @pytest.mark.parametrize(
     "primary_key, expected_primary_key",