Skip to content

Commit e3304b3

Browse files
EshaanAggEshaanAgg
authored
Change the GitHub action to only check for linting and formatting errors [Fixes PalisadoesFoundation#1019] (PalisadoesFoundation#1026)
* Format and lint fixes * Update workflow file * Remove Type-Checker job * Bug fix * Remove ununsed brackets * Fix * Seperate job * Fix typo
1 parent a09b134 commit e3304b3

12 files changed

+193
-208
lines changed

‎.eslintrc.json

+7-21
Original file line numberDiff line numberDiff line change
@@ -10,39 +10,25 @@
1010
],
1111
"overrides": [
1212
{
13-
"files": [
14-
"*.ts"
15-
],
13+
"files": ["*.ts"],
1614
"processor": "@graphql-eslint/graphql"
1715
},
1816
{
19-
"files": [
20-
"*.graphql"
21-
],
17+
"files": ["*.graphql"],
2218
"parser": "@graphql-eslint/eslint-plugin",
23-
"plugins": [
24-
"@graphql-eslint"
25-
]
19+
"plugins": ["@graphql-eslint"]
2620
}
2721
],
2822
"parser": "@typescript-eslint/parser",
2923
"parserOptions": {
3024
"ecmaVersion": "latest",
3125
"sourceType": "module"
3226
},
33-
"plugins": [
34-
"@typescript-eslint"
35-
],
27+
"plugins": ["@typescript-eslint"],
3628
"root": true,
3729
"rules": {
38-
"eqeqeq": [
39-
"error",
40-
"always"
41-
],
42-
"linebreak-style": [
43-
"error",
44-
"unix"
45-
],
30+
"eqeqeq": ["error", "always"],
31+
"linebreak-style": ["error", "unix"],
4632
"no-unused-vars": [
4733
"error",
4834
{
@@ -61,4 +47,4 @@
6147
}
6248
]
6349
}
64-
}
50+
}

‎.github/workflows/pull-request.yml

+21-19
Original file line numberDiff line numberDiff line change
@@ -20,41 +20,43 @@ env:
2020

2121
jobs:
2222
Linter:
23-
name: Lints the code
23+
name: Check for linting errors
2424
runs-on: ubuntu-latest
2525
steps:
2626
- uses: actions/checkout@v3
2727
- name: Install Dependencies
2828
run: npm ci
29-
30-
- name: Run ESLint and Prettier
31-
run: npm run lint
32-
33-
- name: Run Typescript Type-Checker
34-
run: npm run typecheck
35-
29+
- name: Run ESLint to check for linting errors
30+
run: npm run lint:check
3631

3732
Code-Formatter:
38-
name: Formats the code
33+
name: Check for formatting errors
3934
runs-on: ubuntu-latest
4035
needs: Linter
4136
steps:
4237
- name: Checkout
4338
uses: actions/checkout@v3
44-
with:
45-
# This is important to fetch the changes to the previous commit
46-
fetch-depth: 0
47-
- name: Prettify code
48-
uses: creyD/[email protected]
49-
with:
50-
same_commit: True
51-
env:
52-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
39+
- name: Install Dependencies
40+
run: npm ci
41+
- name: Check for fomatting errors
42+
run: npm run format:check
5343

44+
Type-Checker:
45+
name: Check for type errors
46+
runs-on: ubuntu-latest
47+
needs: [Linter, Code-Formatter]
48+
steps:
49+
- name: Checkout
50+
uses: actions/checkout@v3
51+
- name: Install Dependencies
52+
run: npm ci
53+
- name: Run Typescript Type-Checker
54+
run: npm run typecheck
55+
5456
Test-Application:
5557
name: Testing Application
5658
runs-on: ubuntu-latest
57-
needs: Code-Formatter
59+
needs: [Linter, Code-Formatter, Type-Checker]
5860
strategy:
5961
matrix:
6062
node-version: [14.x]

‎locales/en.json

+29-29
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
{
2-
"user.notAuthenticated": "User is not authenticated",
3-
"user.notAuthorized": "User is not authorized for performing this operation",
4-
"user.notFound": "User not found",
5-
"user.alreadyMember": "User is already a member",
6-
"user.profileImage.notFound": "User profile image not found",
7-
"task.notFound": "Task not found",
8-
"event.notFound": "Event not found",
9-
"eventProject.notFound": "Event project not found",
10-
"organization.notFound": "Organization not found",
11-
"organization.profileImage.notFound": "Organization profile image not found",
12-
"organization.member.notFound": "Organization's user is not a member",
13-
"organization.notAuthorized": "Organization is not authorized",
14-
"membershipRequest.notFound": "Membership Request not found",
15-
"membershipRequest.alreadyExists": "Membership Request already exists",
16-
"chat.notFound": "Chat not found",
17-
"email.alreadyExists": "Email address already exists",
18-
"comment.notFound": "Comment not found",
19-
"post.notFound": "Post not found",
20-
"group.notFound": "Group not found",
21-
"invalid.fileType": "Invalid file type",
22-
"invalid.refreshToken": "Invalid refresh token",
23-
"invalid.credentials": "Invalid credentials",
24-
"registrant.alreadyExist": "Already registered for the event",
25-
"member.notFound": "Member not found",
26-
"registrant.alreadyUnregistered": "Already unregistered for the event",
27-
"translation.alreadyPresent": "Translation Already Present",
28-
"translation.notFound": "Translation not found",
29-
"parameter.missing": "Missing Skip parameter. Set it to either 0 or some other value not found"
30-
}
2+
"user.notAuthenticated": "User is not authenticated",
3+
"user.notAuthorized": "User is not authorized for performing this operation",
4+
"user.notFound": "User not found",
5+
"user.alreadyMember": "User is already a member",
6+
"user.profileImage.notFound": "User profile image not found",
7+
"task.notFound": "Task not found",
8+
"event.notFound": "Event not found",
9+
"eventProject.notFound": "Event project not found",
10+
"organization.notFound": "Organization not found",
11+
"organization.profileImage.notFound": "Organization profile image not found",
12+
"organization.member.notFound": "Organization's user is not a member",
13+
"organization.notAuthorized": "Organization is not authorized",
14+
"membershipRequest.notFound": "Membership Request not found",
15+
"membershipRequest.alreadyExists": "Membership Request already exists",
16+
"chat.notFound": "Chat not found",
17+
"email.alreadyExists": "Email address already exists",
18+
"comment.notFound": "Comment not found",
19+
"post.notFound": "Post not found",
20+
"group.notFound": "Group not found",
21+
"invalid.fileType": "Invalid file type",
22+
"invalid.refreshToken": "Invalid refresh token",
23+
"invalid.credentials": "Invalid credentials",
24+
"registrant.alreadyExist": "Already registered for the event",
25+
"member.notFound": "Member not found",
26+
"registrant.alreadyUnregistered": "Already unregistered for the event",
27+
"translation.alreadyPresent": "Translation Already Present",
28+
"translation.notFound": "Translation not found",
29+
"parameter.missing": "Missing Skip parameter. Set it to either 0 or some other value not found"
30+
}

‎locales/fr.json

+29-29
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
{
2-
"user.notAuthenticated": "L'utilisateur n'est pas authentifié",
3-
"user.notAuthorized": "L'utilisateur n'est pas autorisé à effectuer cette opération",
4-
"user.notFound": "Utilisateur introuvable",
5-
"user.alreadyMember": "L'utilisateur est déjà membre",
6-
"user.profileImage.notFound": "Image du profil utilisateur introuvable",
7-
"task.notFound": "Tâche introuvable",
8-
"event.notFound": "Événement non trouvé",
9-
"eventProject.notFound": "Projet d'événement introuvable",
10-
"organization.notFound": "Organisation introuvable",
11-
"organization.profileImage.notFound": "Image du profil de l'organisation introuvable",
12-
"organization.member.notFound": "L'utilisateur de l'organisation n'est pas membre",
13-
"organization.notAuthorized": "L'organisation n'est pas autorisée",
14-
"membershipRequest.notFound": "Demande d'adhésion introuvable",
15-
"membershipRequest.alreadyExists": "La demande d'adhésion existe déjà",
16-
"chat.notFound": "Chat non trouvé",
17-
"email.alreadyExists": "L'adresse e-mail existe déjà",
18-
"comment.notFound": "Commentaire introuvable",
19-
"post.notFound": "Message non trouvé",
20-
"group.notFound": "Groupe introuvable",
21-
"invalid.fileType": "Type de fichier non valide",
22-
"invalid.refreshToken": "Jeton d'actualisation non valide",
23-
"invalid.credentials": "Informations d'identification non valides",
24-
"registrant.alreadyExist": "Déjà inscrit à l'événement",
25-
"member.notFound": "Membre introuvable",
26-
"registrant.alreadyUnregistered": "Déjà non inscrit à l'événement",
27-
"translation.alreadyPresent": "Traduction déjà présente",
28-
"translation.notFound": "Traduction introuvable",
29-
"parameter.missing": "Paramètre de saut manquant. Réglez-le sur 0 ou sur une autre valeur"
30-
}
2+
"user.notAuthenticated": "L'utilisateur n'est pas authentifié",
3+
"user.notAuthorized": "L'utilisateur n'est pas autorisé à effectuer cette opération",
4+
"user.notFound": "Utilisateur introuvable",
5+
"user.alreadyMember": "L'utilisateur est déjà membre",
6+
"user.profileImage.notFound": "Image du profil utilisateur introuvable",
7+
"task.notFound": "Tâche introuvable",
8+
"event.notFound": "Événement non trouvé",
9+
"eventProject.notFound": "Projet d'événement introuvable",
10+
"organization.notFound": "Organisation introuvable",
11+
"organization.profileImage.notFound": "Image du profil de l'organisation introuvable",
12+
"organization.member.notFound": "L'utilisateur de l'organisation n'est pas membre",
13+
"organization.notAuthorized": "L'organisation n'est pas autorisée",
14+
"membershipRequest.notFound": "Demande d'adhésion introuvable",
15+
"membershipRequest.alreadyExists": "La demande d'adhésion existe déjà",
16+
"chat.notFound": "Chat non trouvé",
17+
"email.alreadyExists": "L'adresse e-mail existe déjà",
18+
"comment.notFound": "Commentaire introuvable",
19+
"post.notFound": "Message non trouvé",
20+
"group.notFound": "Groupe introuvable",
21+
"invalid.fileType": "Type de fichier non valide",
22+
"invalid.refreshToken": "Jeton d'actualisation non valide",
23+
"invalid.credentials": "Informations d'identification non valides",
24+
"registrant.alreadyExist": "Déjà inscrit à l'événement",
25+
"member.notFound": "Membre introuvable",
26+
"registrant.alreadyUnregistered": "Déjà non inscrit à l'événement",
27+
"translation.alreadyPresent": "Traduction déjà présente",
28+
"translation.notFound": "Traduction introuvable",
29+
"parameter.missing": "Paramètre de saut manquant. Réglez-le sur 0 ou sur une autre valeur"
30+
}

‎locales/hi.json

+29-29
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
{
2-
"user.notAuthenticated": "उपयोगकर्ता प्रमाणित नहीं है",
3-
"user.notAuthorized": "उपयोगकर्ता इस ऑपरेशन को करने के लिए अधिकृत नहीं है",
4-
"user.notFound": "उपयोगकर्ता नहीं मिला",
5-
"user.alreadyMember": "उपयोगकर्ता पहले से ही एक सदस्य है",
6-
"user.profileImage.notFound": "उपयोगकर्ता प्रोफ़ाइल छवि नहीं मिली",
7-
"task.notFound": "कार्य नहीं मिला",
8-
"event.notFound": "घटना नहीं मिली",
9-
"eventProject.notFound": "इवेंट प्रोजेक्ट नहीं मिला",
10-
"organization.notFound": "संगठन नहीं मिला",
11-
"organization.profileImage.notFound": "संगठन की प्रोफ़ाइल छवि नहीं मिली",
12-
"organization.member.notFound": "संगठन का उपयोगकर्ता सदस्य नहीं है",
13-
"organization.notAuthorized": "संगठन अधिकृत नहीं है",
14-
"membershipRequest.notFound": "सदस्यता अनुरोध नहीं मिला",
15-
"membershipRequest.alreadyExists": "सदस्यता अनुरोध पहले से मौजूद है",
16-
"chat.notFound": "चैट नहीं मिली",
17-
"email.alreadyExists": "ईमेल पहले से मौजूद है",
18-
"comment.notFound": "टिप्पणी नहीं मिली",
19-
"post.notFound": "पोस्ट नहीं मिली",
20-
"group.notFound": "समूह नहीं मिला",
21-
"invalid.fileType": "अमान्य फ़ाइल प्रकार",
22-
"invalid.refreshToken": "अमान्य रीफ़्रेश टोकन",
23-
"invalid.credentials": "अवैध प्रत्यय पत्र",
24-
"registrant.alreadyExist": "घटना के लिए पहले से पंजीकृत",
25-
"member.notFound": "सदस्य अनुपस्थित",
26-
"registrant.alreadyUnregistered": "घटना के लिए पहले से ही अपंजीकृत",
27-
"translation.alreadyPresent": "अनुवाद पहले से मौजूद है",
28-
"translation.notFound": "अनुवाद नहीं मिला",
29-
"parameter.missing": "छोड़ें पैरामीटर मौजूद नहीं है. इसे 0 या किसी अन्य मान पर सेट करें"
30-
}
2+
"user.notAuthenticated": "उपयोगकर्ता प्रमाणित नहीं है",
3+
"user.notAuthorized": "उपयोगकर्ता इस ऑपरेशन को करने के लिए अधिकृत नहीं है",
4+
"user.notFound": "उपयोगकर्ता नहीं मिला",
5+
"user.alreadyMember": "उपयोगकर्ता पहले से ही एक सदस्य है",
6+
"user.profileImage.notFound": "उपयोगकर्ता प्रोफ़ाइल छवि नहीं मिली",
7+
"task.notFound": "कार्य नहीं मिला",
8+
"event.notFound": "घटना नहीं मिली",
9+
"eventProject.notFound": "इवेंट प्रोजेक्ट नहीं मिला",
10+
"organization.notFound": "संगठन नहीं मिला",
11+
"organization.profileImage.notFound": "संगठन की प्रोफ़ाइल छवि नहीं मिली",
12+
"organization.member.notFound": "संगठन का उपयोगकर्ता सदस्य नहीं है",
13+
"organization.notAuthorized": "संगठन अधिकृत नहीं है",
14+
"membershipRequest.notFound": "सदस्यता अनुरोध नहीं मिला",
15+
"membershipRequest.alreadyExists": "सदस्यता अनुरोध पहले से मौजूद है",
16+
"chat.notFound": "चैट नहीं मिली",
17+
"email.alreadyExists": "ईमेल पहले से मौजूद है",
18+
"comment.notFound": "टिप्पणी नहीं मिली",
19+
"post.notFound": "पोस्ट नहीं मिली",
20+
"group.notFound": "समूह नहीं मिला",
21+
"invalid.fileType": "अमान्य फ़ाइल प्रकार",
22+
"invalid.refreshToken": "अमान्य रीफ़्रेश टोकन",
23+
"invalid.credentials": "अवैध प्रत्यय पत्र",
24+
"registrant.alreadyExist": "घटना के लिए पहले से पंजीकृत",
25+
"member.notFound": "सदस्य अनुपस्थित",
26+
"registrant.alreadyUnregistered": "घटना के लिए पहले से ही अपंजीकृत",
27+
"translation.alreadyPresent": "अनुवाद पहले से मौजूद है",
28+
"translation.notFound": "अनुवाद नहीं मिला",
29+
"parameter.missing": "छोड़ें पैरामीटर मौजूद नहीं है. इसे 0 या किसी अन्य मान पर सेट करें"
30+
}

‎locales/sp.json

+29-29
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
{
2-
"user.notAuthenticated": "El usuario no está autenticado",
3-
"user.notAuthorized": "El usuario no está autorizado para realizar esta operación",
4-
"user.notFound": "Usuario no encontrado",
5-
"user.alreadyMember": "El usuario ya es miembro",
6-
"user.profileImage.notFound": "No se encontró la imagen de perfil de usuario",
7-
"task.notFound": "Tarea no encontrada",
8-
"event.notFound": "Evento no encontrado",
9-
"eventProject.notFound": "Proyecto de evento no encontrado",
10-
"organization.notFound": "Organización no encontrada",
11-
"organization.profileImage.notFound": "No se encontró la imagen del perfil de la organización",
12-
"organization.member.notFound": "El usuario de la organización no es miembro",
13-
"organization.notAuthorized": "La organización no está autorizada",
14-
"membershipRequest.notFound": "Solicitud de membresía no encontrada",
15-
"membershipRequest.alreadyExists": "La solicitud de membresía ya existe",
16-
"chat.notFound": "Chat no encontrado",
17-
"email.alreadyExists": "La dirección de correo electrónico ya existe",
18-
"comment.notFound": "Comentario no encontrado",
19-
"post.notFound": "Publicación no encontrada",
20-
"group.notFound": "Grupo no encontrado",
21-
"invalid.fileType": "Tipo de archivo no válido",
22-
"invalid.refreshToken": "Token de actualización no válido",
23-
"invalid.credentials": "Credenciales no válidas",
24-
"registrant.alreadyExist": "Ya inscrito para el evento",
25-
"member.notFound": "Miembro no encontrado",
26-
"registrant.alreadyUnregistered": "Ya no está registrado para el evento",
27-
"translation.alreadyPresent": "Traducción ya presente",
28-
"translation.notFound": "Traducción no encontrada",
29-
"parameter.missing": "Falta el parámetro Omitir. Establézcalo en 0 o en algún otro valor"
30-
}
2+
"user.notAuthenticated": "El usuario no está autenticado",
3+
"user.notAuthorized": "El usuario no está autorizado para realizar esta operación",
4+
"user.notFound": "Usuario no encontrado",
5+
"user.alreadyMember": "El usuario ya es miembro",
6+
"user.profileImage.notFound": "No se encontró la imagen de perfil de usuario",
7+
"task.notFound": "Tarea no encontrada",
8+
"event.notFound": "Evento no encontrado",
9+
"eventProject.notFound": "Proyecto de evento no encontrado",
10+
"organization.notFound": "Organización no encontrada",
11+
"organization.profileImage.notFound": "No se encontró la imagen del perfil de la organización",
12+
"organization.member.notFound": "El usuario de la organización no es miembro",
13+
"organization.notAuthorized": "La organización no está autorizada",
14+
"membershipRequest.notFound": "Solicitud de membresía no encontrada",
15+
"membershipRequest.alreadyExists": "La solicitud de membresía ya existe",
16+
"chat.notFound": "Chat no encontrado",
17+
"email.alreadyExists": "La dirección de correo electrónico ya existe",
18+
"comment.notFound": "Comentario no encontrado",
19+
"post.notFound": "Publicación no encontrada",
20+
"group.notFound": "Grupo no encontrado",
21+
"invalid.fileType": "Tipo de archivo no válido",
22+
"invalid.refreshToken": "Token de actualización no válido",
23+
"invalid.credentials": "Credenciales no válidas",
24+
"registrant.alreadyExist": "Ya inscrito para el evento",
25+
"member.notFound": "Miembro no encontrado",
26+
"registrant.alreadyUnregistered": "Ya no está registrado para el evento",
27+
"translation.alreadyPresent": "Traducción ya presente",
28+
"translation.notFound": "Traducción no encontrada",
29+
"parameter.missing": "Falta el parámetro Omitir. Establézcalo en 0 o en algún otro valor"
30+
}

0 commit comments

Comments
 (0)