getSharedSecret salt issus

[GeekBerry]

ethereum-rsa/src/secret.js

Line 17 in 91c59b4

Buffer.from('mFTNHUGyy6TE0kxZ8LW4bmR0gDdISfii', 'hex'),

it seems gen a Buffer(32) salt by string, but use 'hex' as encoding.
so it is returned <Buffer > which still work.

it is on purpose to confuse implement or a mistake to gen by Buffer.from('mFTNHUGyy6TE0kxZ8LW4bmR0gDdISfii') ?

[sisco0]

That salt is incorrect, as shown at https://nodejs.org/api/buffer.html#Buffers%20and%20character%20encodings it seems that the Buffer is empty because the conversion stops when the first non-hex character is found.
In this case, m, which is the first character is not under the [0-9][A-F] range, so the buffer is empty and the salt is empty as well.
I suggest using 'utf8' instead of 'hex'.

[ghost]

Hello,

We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!

As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

• Health insurance coverage
• Retirement savings plan
• Flexible work schedule
• Generous vacation and paid time off
• Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.

Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.

Important: You have 24 hours to complete the application process.

If you have any questions or need further information, please don't hesitate to contact us.

Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.

Best regards,
GitHub Recruitment Team
vitustockholm, @starbt, @sauravs, @yclsl, @FranciscoDA, @washboardalex, @J-keaper, @untitledH, @carlowang2001, @17535250630, @clintono1, @Fcukkkkkkman, @MSloyan, @cgallic, @pause125, @izayl, @thiras, @dharmendrakariya, @ssdjet, @fast8888