Backport PR matplotlib#30497: TST: Use a temporary directory for test_save_figure_return

Author: dstansby

lib/matplotlib/tests/test_backend_qt.py

@@ -219,14 +219,15 @@ def test_figureoptions():
 
 
 @pytest.mark.backend('QtAgg', skip_on_importerror=True)
-def test_save_figure_return():
+def test_save_figure_return(tmp_path):
     fig, ax = plt.subplots()
     ax.imshow([[1]])
+    expected = tmp_path / "foobar.png"
     prop = "matplotlib.backends.qt_compat.QtWidgets.QFileDialog.getSaveFileName"
-    with mock.patch(prop, return_value=("foobar.png", None)):
+    with mock.patch(prop, return_value=(str(expected), None)):
         fname = fig.canvas.manager.toolbar.save_figure()
-        os.remove("foobar.png")
-        assert fname == "foobar.png"
+        assert fname == str(expected)
+        assert expected.exists()
     with mock.patch(prop, return_value=(None, None)):
         fname = fig.canvas.manager.toolbar.save_figure()
         assert fname is None