Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: queryParams type error #460

Open
Op-Pautu opened this issue Feb 11, 2025 · 1 comment
Open

[bug]: queryParams type error #460

Op-Pautu opened this issue Feb 11, 2025 · 1 comment
Labels
bug Something isn't working status: needs triaging

Comments

@Op-Pautu
Copy link

Op-Pautu commented Feb 11, 2025

Package.json file

{
  "name": "medusa-next",
  "version": "1.0.3",
  "private": true,
  "author": "Kasper Fabricius Kristensen <[email protected]> & Victor Gerbrands <[email protected]> (https://www.medusajs.com)",
  "description": "Next.js Starter to be used with Medusa V2",
  "keywords": [
    "medusa-storefront"
  ],
  "scripts": {
    "dev": "next dev --turbopack -p 8000",
    "build": "next build",
    "start": "next start -p 8000",
    "lint": "next lint",
    "analyze": "ANALYZE=true next build"
  },
  "dependencies": {
    "@headlessui/react": "^2.2.0",
    "@medusajs/js-sdk": "latest",
    "@medusajs/ui": "latest",
    "@radix-ui/react-accordion": "^1.2.1",
    "@stripe/react-stripe-js": "^1.7.2",
    "@stripe/stripe-js": "^1.29.0",
    "lodash": "^4.17.21",
    "next": "15.0.3",
    "pg": "^8.11.3",
    "qs": "^6.12.1",
    "react": "19.0.0-rc-66855b96-20241106",
    "react-country-flag": "^3.1.0",
    "react-dom": "19.0.0-rc-66855b96-20241106",
    "server-only": "^0.0.1",
    "tailwindcss-radix": "^2.8.0",
    "webpack": "^5"
  },
  "devDependencies": {
    "@babel/core": "^7.17.5",
    "@medusajs/types": "latest",
    "@medusajs/ui-preset": "latest",
    "@types/lodash": "^4.14.195",
    "@types/node": "17.0.21",
    "@types/pg": "^8.11.0",
    "@types/react": "^18.3.12",
    "@types/react-dom": "^18.3.1",
    "@types/react-instantsearch-dom": "^6.12.3",
    "ansi-colors": "^4.1.3",
    "autoprefixer": "^10.4.2",
    "babel-loader": "^8.2.3",
    "eslint": "8.10.0",
    "eslint-config-next": "15.0.3",
    "postcss": "^8.4.8",
    "prettier": "^2.8.8",
    "tailwindcss": "^3.0.23",
    "typescript": "^5.3.2"
  },
  "packageManager": "[email protected]",
  "resolutions": {
    "@types/react": "npm:[email protected]",
    "@types/react-dom": "npm:[email protected]"
  },
  "overrides": {
    "react": "19.0.0-rc-66855b96-20241106",
    "react-dom": "19.0.0-rc-66855b96-20241106"
  }
}

Node.js version

v20.18.0

Operating system name and version

Windows 10 Pro 22H2

Browser name

No response

What happended?

Product Rail and a bunch of other components when using listProducts with queryParams give type errors.

const { response: { products: pricedProducts }, } = await listProducts({ queryParams: { collection_id: collection.id, fields: "*variants.calculated_price", }, })

Object literal may only specify known properties, and 'collection_id' does not exist in type 'FindParams & StoreProductParams'

const queryParams: HttpTypes.StoreProductParams = {}
 if (region?.id) {
   queryParams.region_id = region.id
 }
 if (product.collection_id) {
   queryParams.collection_id = [product.collection_id]
 }
 if (product.tags) {
   queryParams.tag_id = product.tags
     .map((t) => t.id)
     .filter(Boolean) as string[]
 }
 queryParams.is_giftcard = false

Property 'collection_id' does not exist on type 'StoreProductParams'.

Property 'is_giftcard' does not exist on type 'StoreProductParams'.
etc

Expected behavior

ProductRail and RelatedProducts components should render something from medusa backend

Actual behavior

ProductRail and RelatedProducts components do not do anything

Link to reproduction repo

https://github.com/medusajs/nextjs-starter-medusa

@Op-Pautu Op-Pautu added bug Something isn't working status: needs triaging labels Feb 11, 2025
@freebreix
Copy link

yes this should get fixed.
props like id and handle are also not part of StoreProductParams anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: needs triaging
Projects
None yet
Development

No branches or pull requests

2 participants