Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old navigation design from CHT #9665

Open
latin-panda opened this issue Nov 25, 2024 · 2 comments
Open

Remove old navigation design from CHT #9665

latin-panda opened this issue Nov 25, 2024 · 2 comments
Milestone

Comments

@latin-panda
Copy link
Contributor

Description
Remove the old navigation code to simplify the maintenance of CHT.

CHT released the new navigation design in v4.12. Projects upgrading to 4.12 will automatically have the new navigation design. However, if necessary, the old navigation can be shown by enabling permissions for specific user roles (can_view_old_navigation). This capability/permission is considered deprecated and will be removed in a future release (communications about this deprecation have been done in round-up calls, release notes, and forum posts from the start of this project)

Having both adds extra complexity to the maintainers' efforts to add, modify, or fix features in CHT. They must ensure that each feature is displayed correctly and works well in new and old designs.

Six months after v4.12 release, it's recommended to evaluate if partners use can_view_old_navigation and schedule removing the old navigation accordingly.

@latin-panda
Copy link
Contributor Author

@andrablaj @jkuester, please monitor this. It will improve the contributors' experience working with CHT.
While keeping both designs, ensure the contributors test their work in the old and new designs. I opened a PR to add a reminder for when someone opens a PR.

@jkuester jkuester added this to the 5.0.0 milestone Nov 25, 2024
@jkuester
Copy link
Contributor

Tagging this for the 5.0.0 release if we do not do it sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants