Skip to content

Fix notice: 'Only variables should be assigned by reference' #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szotsaki wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix notice: 'Only variables should be assigned by reference' #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions WikilogFeed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,9 +507,9 @@ public function formatFeedEntry( $row ) {

# Make titles.
$wikilogName = str_replace( '_', ' ', $row->wlw_title );
$wikilogTitle =& Title::makeTitle( $row->wlw_namespace, $row->wlw_title );
$wikilogTitle = Title::makeTitle( $row->wlw_namespace, $row->wlw_title );
$itemName = str_replace( '_', ' ', $row->wlp_title );
$itemTitle =& Title::makeTitle( $row->page_namespace, $row->page_title );
$itemTitle = Title::makeTitle( $row->page_namespace, $row->page_title );

# Retrieve article parser output
list( $article, $parserOutput ) = WikilogUtils::parsedArticle( $itemTitle, true );
Expand Down
12 changes: 6 additions & 6 deletions WikilogParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class WikilogParser
* ParserFirstCallInit hook handler function.
*/
public static function FirstCallInit( $parser ) {
$mwSummary =& MagicWord::get( 'wlk-summary' );
$mwSummary = MagicWord::get( 'wlk-summary' );
foreach ( $mwSummary->getSynonyms() as $tagname ) {
$parser->setHook( $tagname, array( 'WikilogParser', 'summary' ) );
}
Expand Down Expand Up @@ -134,7 +134,7 @@ public static function InternalParseBeforeLinks( $parser, &$text, $stripState )
if ( $parser->mExtWikilogInfo && $parser->mExtWikilogInfo->isItem() ) {
static $moreRegex = false;
if ( $moreRegex === false ) {
$mwMore =& MagicWord::get( 'wlk-more' );
$mwMore = MagicWord::get( 'wlk-more' );
$words = $mwMore->getBaseRegex();
$flags = $mwMore->getRegexCase();
$moreRegex = "/(?<=^|\\n)--+ *(?:$words) *--+\s*/$flags";
Expand Down Expand Up @@ -207,7 +207,7 @@ public static function GetFullURL( $title, &$url, $query ) {
* Summary tag parser hook handler.
*/
public static function summary( $text, $params, $parser ) {
$mwHidden =& MagicWord::get( 'wlk-hidden' );
$mwHidden = MagicWord::get( 'wlk-hidden' );

# Remove extra space to make block rendering easier.
$text = trim( $text );
Expand All @@ -224,9 +224,9 @@ public static function settings( $parser /* ... */ ) {
global $wgOut;
self::checkNamespace( $parser );

$mwIcon =& MagicWord::get( 'wlk-icon' );
$mwLogo =& MagicWord::get( 'wlk-logo' );
$mwSubtitle =& MagicWord::get( 'wlk-subtitle' );
$mwIcon = MagicWord::get( 'wlk-icon' );
$mwLogo = MagicWord::get( 'wlk-logo' );
$mwSubtitle = MagicWord::get( 'wlk-subtitle' );

$args = array_slice( func_get_args(), 1 );
foreach ( $args as $arg ) {
Expand Down