Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-identifiers in export/imports #2536

Open
4 tasks done
wooorm opened this issue Sep 13, 2024 · 2 comments
Open
4 tasks done

Add support for non-identifiers in export/imports #2536

wooorm opened this issue Sep 13, 2024 · 2 comments
Labels
🌊 blocked/upstream This cannot progress before something external happens first

Comments

@wooorm
Copy link
Member

wooorm commented Sep 13, 2024

Initial checklist

Affected packages and versions

all, probably

Link to runnable example

No response

Steps to reproduce

import { 'alpha-bravo' as charlieDelta } from 'echo'
export { 'foxtrot-golf' as 'hotel-india' } from 'juliet'

Expected behavior

should work, somehow, probably.

Actual behavior

davidbonnet/astring#713

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

@wooorm
Copy link
Member Author

wooorm commented Sep 13, 2024

I confirmed on the playground that this now compiles to the broken code:

import {undefined as charlieDelta} from 'echo';
export {undefined} from 'juliet';

…due to the astring bug

@wooorm
Copy link
Member Author

wooorm commented Oct 2, 2024

This was also just added to the @types/estree: DefinitelyTyped/DefinitelyTyped#70504.

wooorm added a commit that referenced this issue Oct 2, 2024
* fix for changes in  `@types/estree`,
  more will happen later for #2536.
@wooorm wooorm changed the title Add some tests for non-identifiers in export/imports Add support for non-identifiers in export/imports Oct 2, 2024
@wooorm wooorm added the 🌊 blocked/upstream This cannot progress before something external happens first label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 blocked/upstream This cannot progress before something external happens first
Development

No branches or pull requests

1 participant