-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomElementRegistry needs updating #6617
Comments
@hamishwillee you had a significant update in #30566, does that PR resolve this issue or are there still gaps in your opinion? |
I did not touch this. I'd need to do a fair bit of work to understand if the solution/work indicated is needed, but I can see that some work is needed for sure. What I do know ... So the linked HTML spec talks about booleans What is documented is that in Similarly, you can specify "internals" in So what I'd say is that The specific suggestion to add info about this to CustomElementRegistry might not be the right place - depends on where the failure point is - if this shows up when you register a custom element, then yes, it would make sense to have that information here. |
I've been documenting ElementInternals, in the process of this I think that the documentation we have for custom elements may need some updating. In particular I noticed that https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry includes no information about the disable internals, or disable shadow booleans.
https://html.spec.whatwg.org/multipage/custom-elements.html#concept-custom-element-definition-disable-internals
I think it would probably be worth someone taking a look at this content and seeing what else needs updating.
Once updated it would be good to link this to the information about attachInternals in /Web/API/Element/attachInternals
The text was updated successfully, but these errors were encountered: