Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Svelte] "Check All / Uncheck All" UX problems. #5829

Open
luc4leone opened this issue Jun 9, 2021 · 1 comment
Open

[Svelte] "Check All / Uncheck All" UX problems. #5829

luc4leone opened this issue Jun 9, 2021 · 1 comment
Labels
Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees

Comments

@luc4leone
Copy link

MDN URL: https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_reactivity_lifecycle_accessibility

What information was incorrect, unhelpful, or incomplete?

I think the "Check all / Uncheck all" functionality implementation might have a problem from a UX perspective.

Specific section or headline?

https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_reactivity_lifecycle_accessibility#working_on_the_moreactions_component

What did you expect to see?

I would expect this kind of behavior https://todomvc.com/examples/jquery/#/all.
Expected: Uncheck All button state when all the todos are checked, otherwise Check All button.

There are a few use cases now where the user might be confused by the UI behavior. For example, if you go the repl for this article https://svelte.dev/repl/d1fa84a5a4494366b179c87395940039?version=3.23.2 and check the third todo, you would expect the Check All to change to Uncheck All since all the todos are now checked.

Did you test this? If so, how?

You can test the implementation in the svelte repl, there's a link at the bottom of the article: https://svelte.dev/repl/d1fa84a5a4494366b179c87395940039?version=3.23.2

MDN Content page report details
@Rumyra Rumyra added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 25, 2021
@sideshowbarker sideshowbarker added Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Mar 22, 2022
@ccozens
Copy link

ccozens commented Jun 27, 2023

I've just worked through this tutorial and switching between "Check all / Uncheck all" is the functionality in the current version of the tutorial:
<button type="button" class="btn btn__primary" on:click={checkAll}>{completed ? 'Check' : 'Uncheck'} all</button>
from point 2 of Working on the MoreActions component

@Josh-Cena Josh-Cena changed the title Issue with "Advanced Svelte: Reactivity, lifecycle, accessibil…": "Check All / Uncheck All" UX problems. [Svelte] "Check All / Uncheck All" UX problems. Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees
Projects
None yet
Development

No branches or pull requests

6 participants